public inbox for [email protected]  

help / color / mirror / Atom feed

From: Mark Dilger <[email protected]>
To: Jeff Davis <[email protected]>
Cc: John Naylor <[email protected]>
Cc: [email protected]
Cc: Andrey Borodin <[email protected]>
Subject: Re: GUC parameter ACLs and physical walsender
Date: Thu, 23 Apr 2026 16:41:13 -0700
Message-ID: <CAHgHdKs7XL5mPOVtc4JU300Ku-9FHX9Lbgy_G=P+-0D2Nu0PTw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CANWCAZZOSBuypxdGA-VJ9p5deDqAH1F48aXe58ABaP7cjsZyQg@mail.gmail.com>
	<CAHgHdKsciwDvZkyUi+=i-tjK3CdD3DCccLgA2wT5AEzXdM0aHg@mail.gmail.com>
	<[email protected]>

On Thu, Apr 23, 2026 at 2:06 PM Jeff Davis <[email protected]> wrote:

> On Thu, 2026-04-23 at 10:57 -0700, Mark Dilger wrote:
> > John is right that the hardcoded BKI_ROWTYPE_OID(2173) makes this
> > non-backportable as-is.
>
> Right, but that leaves the questions:
>
> (a) Is this the right fix for master?
>

Yes.  This approach has no problem in master that I can see.


> (b) Is there anything we can do in the back branches, or we just leave
> it as fix going forward only?
>

I don't see a solution.  We could try to replace the error message with
something better, but even that seems hard to phrase.  Replacing
"cannot read pg_class without having selected a database" with, say,
"permission denied" would also be confusing for a role which does have
the privilege but just can't verify it.

-- 

*Mark Dilger*

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: GUC parameter ACLs and physical walsender
  In-Reply-To: <CAHgHdKs7XL5mPOVtc4JU300Ku-9FHX9Lbgy_G=P+-0D2Nu0PTw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox