public inbox for [email protected]  
help / color / mirror / Atom feed
From: Peter Smith <[email protected]>
To: Ashutosh Sharma <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Include sequences in publications created by pg_createsubscriber
Date: Thu, 25 Jun 2026 17:57:46 +1200
Message-ID: <CAHut+PsTUJLhPyUq84KfEnMwjmFz0813_LAOk57F+TFmBqwF6g@mail.gmail.com> (raw)
In-Reply-To: <CAE9k0PmZKp_zSNRm7KoLzOjaxnxUjLmA-W02fhg11fqEjB50Vw@mail.gmail.com>
References: <CALDaNm2RYQRLjexRJOpiZOFkspp8PRgoh6S7d2y003TJ_TSSZA@mail.gmail.com>
	<CAHut+PtGOeXr69qQRgq_DW=BEEix_6bDsgmR8Vk4_qbNy5BvAA@mail.gmail.com>
	<CALDaNm05u0UvteGQf_9wKbUFujO0JvJk=GnTeZyxsdB0bmPtcg@mail.gmail.com>
	<CAHut+PsKCgwTP-6TxdwcNT5FT3dTyJiVfEKMPJR1K3df0EbOqQ@mail.gmail.com>
	<CAE9k0PmZKp_zSNRm7KoLzOjaxnxUjLmA-W02fhg11fqEjB50Vw@mail.gmail.com>

On Thu, Jun 25, 2026 at 5:35 PM Ashutosh Sharma <[email protected]> wrote:
>
> Hi,
>
> On Thu, Jun 25, 2026 at 6:29 AM Peter Smith <[email protected]> wrote:
> >
> > 3.
> >       <para>
> >        Enable the subscription for each specified database on the target server.
> >        The subscription starts applying transactions from the replication start
> > -      point.
> > +      point. The subscription is configured to include sequences.
> >       </para>
> >
> > This implies there was some special subscription "configuration" for
> > getting sequences, but it just gets sequences because sequences were
> > published. Maybe you don't need to say anything here. Or, maybe reword
> > to just say "The subscription will include sequences".
> >
>
> What if the subscription uses an existing publication that doesn't
> include sequences? In that case, would it be correct to say that the
> subscription will include sequences?
>

Oops. Fair point. Looks like the original patch text suffered similar issues.

A more descriptive explanation seems needed for this to talk about the
differences of internal publications versus user-supplied ones....
e.g. a user-publication may even be only FOR ALL SEQUENCES and not
even have tables in them... then what?

======
Kind Regards,
Peter Smith.
Fujitsu Australia.






view thread (23+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Include sequences in publications created by pg_createsubscriber
  In-Reply-To: <CAHut+PsTUJLhPyUq84KfEnMwjmFz0813_LAOk57F+TFmBqwF6g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox