public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Smith <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
Date: Fri, 12 Jun 2026 08:57:33 +1000
Message-ID: <CAHut+Pt2L5jAS2qXDENa2-+0dX2gH+kFWQbfkE3uzCoSRrjGFA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHut+Pu7LWQB+m9HTf4nf3BQu8bC_-N5c=kuOf=EHHZE_Ctj9Q@mail.gmail.com>
	<[email protected]>

On Fri, Jun 12, 2026 at 2:44 AM Álvaro Herrera <[email protected]> wrote:
>
> On 2026-Apr-24, Peter Smith wrote:
>
> > OK. Including the comma within a larger translated string seems like a
> > better idea.
> [...]
> > Also, why did you choose to implement `last` versus `first` logic?
> > e.g. How about this?
>
> In the end I decided to go with the flow and changed to use "first"
> logic rather than "last".  I also figured that we should change the
> other two places you pointed out at the start of the thread to use the
> same coding style.  Since this is mostly cosmetic, I don't feel
> compelled to back-patch it, and pushed only to master.
>

Thanks for pushing!

> Another place I noticed while looking this over is psql's
> describeOneTableDetails(), per the attached patch.  It's essentially
> more of the same, but arguably different enough that I judged it
> warranted posting before pushing.
>

This additional patch LGTM.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Redundant/mis-use of _(x) gettext macro?
  In-Reply-To: <CAHut+Pt2L5jAS2qXDENa2-+0dX2gH+kFWQbfkE3uzCoSRrjGFA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox