public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Smith <[email protected]>
To: David Rowley <[email protected]>
Cc: PostgreSQL Developers <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Subject: Re: Get rid of translation strings that only contain punctuation
Date: Wed, 22 Apr 2026 11:17:31 +1000
Message-ID: <CAHut+PvGk6H=B72_3YmyyZp8ZW=aYoSsoGrtiBEuMNUHHXXFmQ@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvoFSu5zLFvx96aZ5wvL7tcB9aR2hBPCaMPs8D_f0Z7eSw@mail.gmail.com>
References: <CAApHDvoFSu5zLFvx96aZ5wvL7tcB9aR2hBPCaMPs8D_f0Z7eSw@mail.gmail.com>

On Wed, Apr 22, 2026 at 10:30 AM David Rowley <[email protected]> wrote:
>
> (Follow-on work from [1])
>
> We've got a few parts of the code that translate strings that contain
> only a single punctuation character. I'm not a translator, but I
> suspect that these would be tricky to deal with as such short strings
> could be used for various different things, and if the required
> translation was to differ between requirements, then you're out of
> luck.
>
> I looked at: git grep -A 1 "msgid \", \"" and I see French is the only
> translation to do anything different with the ", " string, and only in
> psql.
>
> src/bin/psql/po/fr.po:msgid ", "
> src/bin/psql/po/fr.po-msgstr " , "
>
> This is used for suffixing "unique" or "unique nulls not distinct". I
> adjusted the logic there to get rid of the short translation string.
>
> Quite a few are new to v19: fd366065e (AmitK), 48efefa6c (AmitK),
> 0fc33b005 (PeterE)
> The relation.c one is from v18: 8fcd80258 (AmitK)
> The describe.c one is from v15: 94aa7cc5f (PeterE)
>
> Should we get rid of these?
>

This question overlaps with another thread of mine [1].

There, I was told that a punctuation double-quote (")  *should* be translated.

OTOH, I did not see why the comma separator (,) should be translated
-- my patch did so only to be the same as existing code.

======
[1] https://www.postgresql.org/message-id/CAHut%2BPui7RaQ8OfJEVn2ry-ykjnGc%2B3ujsFmcHDFw9FsXw_tRw%40mail...

Kind Regards,
Peter Smith.
Fujitsu Australia

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Get rid of translation strings that only contain punctuation
  In-Reply-To: <CAHut+PvGk6H=B72_3YmyyZp8ZW=aYoSsoGrtiBEuMNUHHXXFmQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox