public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Smith <[email protected]>
To: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
Date: Mon, 13 Apr 2026 12:14:59 +1000
Message-ID: <CAHut+PvtmM7tCut-K-EWSq0_Hg5ey=M2NreU_Fq80SpUOgmiBw@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1KUP5h++hSK6eo--jx=jRJ2TTPqYYmOg=7anCm=__S_0w@mail.gmail.com>
References: <CAHut+Pt3t_tCYwDStkj5fG4Z=YXrHvPBA7iGdh745QipC5zKeg@mail.gmail.com>
	<CAA4eK1KUP5h++hSK6eo--jx=jRJ2TTPqYYmOg=7anCm=__S_0w@mail.gmail.com>

On Fri, Apr 10, 2026 at 8:19 PM Amit Kapila <[email protected]> wrote:
>
> On Fri, Apr 10, 2026 at 12:43 PM Peter Smith <[email protected]> wrote:
> >
> > Notice that that the describe publication says:
> > "Tables:" and "Except tables:" (Lowercase "tables")
> >
> > Notice that the describe table says:
> > "Publications:" and "Except Publications:"  (Uppercase "Publications")
> >
> > I think they should use a consistent case:
> > eg1. (both lowercase) Except tables; Except publications, OR
> > eg2. (bother uppercase) Except Tables; Except Publications
> >
>
> We should follow eg1. I checked few examples where we follow same
> pattern as eg1:
>
> Example-1: (See: "Tables from schemas")
>  postgres=# \dRp+ pub1
>                                                      Publication pub1
>  Owner | All tables | All sequences | Inserts | Updates | Deletes |
> Truncates | Generated columns | Via root | Description
> -------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+-------------
>  amit  | f          | f             | t       | t       | t       | t
>        | none              | f        |
> Tables from schemas:
>     "sch1"
>
> Example-2: ((See: "No connections")
> postgres=# create user u1 CONNECTION LIMIT 0;
> CREATE ROLE
> postgres=# \du u1
>        List of roles
>  Role name |   Attributes
> -----------+----------------
>  u1        | No connections
>

Hi Amit.

Thanks for the advice.

PSA patch v1 to change "Except Publications" to "Except publications".

======
Kind Regards,
Peter Smith.
Fujitsu Australia


Attachments:

  [application/octet-stream] v1-0001-describe-table-except-publications.patch (1.8K, 2-v1-0001-describe-table-except-publications.patch)
  download | inline diff:
From d28f4edd28e15c3af682c6bda2c34aa44eaa9c38 Mon Sep 17 00:00:00 2001
From: Peter Smith <[email protected]>
Date: Mon, 13 Apr 2026 12:12:00 +1000
Subject: [PATCH v1] describe table except publications

---
 src/bin/psql/describe.c                   | 2 +-
 src/test/regress/expected/publication.out | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 4e8ff00394a..291c493f594 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -3306,7 +3306,7 @@ describeOneTableDetails(const char *schemaname,
 				tuples = PQntuples(result);
 
 			if (tuples > 0)
-				printTableAddFooter(&cont, _("Except Publications:"));
+				printTableAddFooter(&cont, _("Except publications:"));
 
 			/* Might be an empty set - that's ok */
 			for (i = 0; i < tuples; i++)
diff --git a/src/test/regress/expected/publication.out b/src/test/regress/expected/publication.out
index a9059a39138..d028e9be866 100644
--- a/src/test/regress/expected/publication.out
+++ b/src/test/regress/expected/publication.out
@@ -252,7 +252,7 @@ Indexes:
     "testpub_tbl1_pkey" PRIMARY KEY, btree (id)
 Publications:
     "testpub_foralltables"
-Except Publications:
+Except publications:
     "testpub_foralltables_excepttable"
     "testpub_foralltables_excepttable1"
 
@@ -435,7 +435,7 @@ Except tables:
 --------+---------+-----------+----------+---------
  a      | integer |           |          | 
 Partition of: testpub_root FOR VALUES FROM (0) TO (100)
-Except Publications:
+Except publications:
     "testpub8"
 
 \d testpub_root
@@ -444,7 +444,7 @@ Except Publications:
 --------+---------+-----------+----------+---------
  a      | integer |           |          | 
 Partition key: RANGE (a)
-Except Publications:
+Except publications:
     "testpub8"
 Number of partitions: 1 (Use \d+ to list them.)
 
-- 
2.47.3

view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
  In-Reply-To: <CAHut+PvtmM7tCut-K-EWSq0_Hg5ey=M2NreU_Fq80SpUOgmiBw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox