public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aleksander Alekseev <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Jacob Champion <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Nazir Bilal Yavuz <[email protected]>
Subject: Re: RFC: adding pytest as a supported test framework
Date: Mon, 19 Jan 2026 14:34:37 +0300
Message-ID: <CAJ7c6TMt-aXXmtO9JgXEsh4UvWrPQbW4_CnRxftAacW0QM9a5g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAOYmi+nEqA2LmetcJKUDmctypPLLumkVwj3vQ3idYd8yAGza5Q@mail.gmail.com>
<CAOYmi+kebAt6wSX7ee0c0kMzV7r0hp93bAt10V5a88yHHUKwog@mail.gmail.com>
<CAOYmi+=CrBFBRX-foRRES2tx2wXBJJhbsJGjgFbWvPcmBJuK-Q@mail.gmail.com>
<[email protected]>
<[email protected]>
<g4gdtfedwwdgu5sbcopjt3djtqk6p2q7n5nymp7ppapfwukoyd@ev2v4jtsbure>
<CAOYmi+mV97+FC=ME0EZj+3LBFHZ3g_xGmTGA_3u+TwJ_pvpFWw@mail.gmail.com>
<[email protected]>
<baqtdyuunu42yu7ler4bflifksznt7u7tywj4atdtcxwxhxinj@76taubczsku2>
<CAGECzQTzG0otdj7Z6--FOtbLLiceJ+eWn3dqRYr6-toG+RWcEg@mail.gmail.com>
<froy7mvxq76o2asuyzajyvaqelzuv372xsylfvhlhkvis7ojr4@23lg5adaxvdw>
<[email protected]>
<[email protected]>
Hi,
> v10 attached to resolve merge conflicts.
I tested and reviewed patches 0001 .. 0003 on Linux x64. All in all
the code is in a pretty good shape except for several TODOs:
```
# TODO: proper quoting
v = v.replace("\\", "\\\\")
v = v.replace("'", "\\'")
v = "'{}'".format(v)
```
and:
```
# TODO: rather than using callback(), consider explicitly signaling
# the fn() implementation to stop early if we get an exception.
# Otherwise we'll hang until the end of the timeout.
self._thread = threading.Thread(target=_bg)
self.callback(self._join)
```
Are there any plans to rewrite this code? If not, maybe there should
be no TODOs in the comments?
Also leaving this:
```
# XXX interacts poorly with testwrap's boilerplate diagnostics
# self.print("TAP version 13")
```
... doesn't seem to be particularly useful. I see XXX but what are
actionable items? If there are none, perhaps there shouldn't be XXX
here.
I haven't looked at 0004 and 0005.
--
Best regards,
Aleksander Alekseev
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: RFC: adding pytest as a supported test framework
In-Reply-To: <CAJ7c6TMt-aXXmtO9JgXEsh4UvWrPQbW4_CnRxftAacW0QM9a5g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox