public inbox for [email protected]
help / color / mirror / Atom feedFrom: Robert Treat <[email protected]>
To: Amit Kapila <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add missing period to HINT messages
Date: Mon, 13 Apr 2026 20:39:04 -0400
Message-ID: <CAJSLCQ08y3pECMLyLE7-GKZ9n3mHRx3Pru0ji_W0y0GX0O5zjg@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1JmqgZQ9HRvF6t7Eie6Z4sDGAEyH5fYbt1F69tvwLFUdQ@mail.gmail.com>
References: <CAHut+PvikGr4AtoFSs=jq=hmTybVF2NCMEZ57-sjwbGudfuqsQ@mail.gmail.com>
<[email protected]>
<CAHut+PsUQfddBnjE9m1x4aoWAgRMEnsVFeg2cZJt9BCC_nbwfg@mail.gmail.com>
<[email protected]>
<CAHut+PuxV8wAULnNv+i1_YKyvDrD7jvWne48Yf82e3hRR=+qQw@mail.gmail.com>
<CABV9wwPNeMM9wrtYtwmG_F6y=-f8hcnPbeVMmgXE4DEaZkFQew@mail.gmail.com>
<CAHut+PsdwfnT3yMM8r9y7c5MZU2sv27JJd2riFipdQ8PvXs7Dw@mail.gmail.com>
<CAA4eK1JmqgZQ9HRvF6t7Eie6Z4sDGAEyH5fYbt1F69tvwLFUdQ@mail.gmail.com>
On Mon, Apr 13, 2026 at 4:28 AM Amit Kapila <[email protected]> wrote:
> On Mon, Apr 13, 2026 at 6:32 AM Peter Smith <[email protected]> wrote:
> > On Fri, Apr 10, 2026 at 11:10 PM Robert Treat <[email protected]> wrote:
> > >
> > > On Thu, Apr 9, 2026 at 9:05 PM Peter Smith <[email protected]> wrote:
> > > > On Thu, Apr 9, 2026 at 1:34 PM Chao Li <[email protected]> wrote:
> > > > >
> > > > ...
> > > > >
> > > > > I am not sure if your scope includes contrib/, if yes, I am sure you will find some occurrences there.
> > > > >
> > > >
> > > > Updated one more message found in contrib.
> > > >
> > > > PSA v2.
> > > >
> > >
> > > +1 to the general idea here, although at the risk of looking at
> > > patches before the morning coffee has settled in, ISTM you might have
> > > missed some entries? And/or this patch isn't against HEAD? For
> > > example, you seem to be catching the line here
> > > https://github.com/postgres/postgres/blame/009ea1b08d7b8843435bd0f1137fa3df09aac79f/src/test/regress...,
> > > but not the one on line 52, maybe because it looks like a comment (but
> > > istm we should clean these all up. no?)
> > >
> >
> > Thanks for your review!
> >
> > Yes, the patch applies to HEAD. It looks like I was a bit slack in
> > updating some test comments. Hopefully, I have found them all now.
> >
>
> BTW, I find such a code cleanup exercise can be done even after
> feature freeze. If so, shall we do it as a HEAD-only patch or do it in
> bank branches as well?
>
I don't have a strong opinion on it, but I think generally that clean
up patches (where we aren't fixing some kind of document mistake or
misleading information) generally just go into HEAD for the next
release, though if it easily applies cleanly to back branches and you
want to do it, it's probably ok to apply it backwards, but I wouldn't
spend any time on it if it didn't.
Robert Treat
https://xzilla.net
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add missing period to HINT messages
In-Reply-To: <CAJSLCQ08y3pECMLyLE7-GKZ9n3mHRx3Pru0ji_W0y0GX0O5zjg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox