public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Treat <[email protected]>
To: Marcos Pegoraro <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Antonin Houska <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Mihail Nikalayeu <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Thu, 25 Sep 2025 17:31:35 -0400
Message-ID: <CAJSLCQ38JzwVr+O1G9WhVw+G5MuECCD0T_e55097m9-gc2qfnQ@mail.gmail.com> (raw)
In-Reply-To: <CAB-JLwZTViGAi01hC9_G4HNwL59W4tKovFPuoL+7ZLwsiKDiiw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAB-JLwZTViGAi01hC9_G4HNwL59W4tKovFPuoL+7ZLwsiKDiiw@mail.gmail.com>

On Thu, Sep 25, 2025 at 4:21 PM Marcos Pegoraro <[email protected]> wrote:
>
> Em qui., 25 de set. de 2025 às 15:12, Álvaro Herrera <[email protected]> escreveu:
>
> Some typos I've found on usage of pg_repackdb.
>
> + printf(_("  -n, --schema=SCHEMA             repack tables in the specified schema(s) only\n"));
> + printf(_("  -N, --exclude-schema=SCHEMA     do not repack tables in the specified schema(s)\n"));
> both options can point to a single schema, so "(s)" should be removed.
> "in the specified schema(s)" should be "in the specified schema"
>
> Same occurs on this one, which should be table, not table(s)
> + printf(_("  -t, --table='TABLE'             repack specific table(s) only\n"));
>

This pattern is used because you can pass more than one argument, for
example, something like

pg_repackdb -d pagila -v -n public -n legacy

While I agree that the wording is a little awkward; I'd prefer "repack
tables only in the specified schema(s)"; but this follows the same
pattern as pg_dump and friends.

Robert Treat
https://xzilla.net

view thread (106+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Adding REPACK [concurrently]
  In-Reply-To: <CAJSLCQ38JzwVr+O1G9WhVw+G5MuECCD0T_e55097m9-gc2qfnQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox