public inbox for [email protected]  

help / color / mirror / Atom feed

From: shveta malik <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Andreas Karlsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: shveta malik <[email protected]>
Subject: Re: doc: Improve wal_level and effective_wal_level GUC around logical replication
Date: Wed, 8 Apr 2026 09:29:59 +0530
Message-ID: <CAJpy0uAv36NnfLH=t+XUbwF+o1DYvF4P+cFbwh9R2DvmRW7nQg@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwb3dG_tLFbWc_A_NMu-1b7xfGhPBa=dnAGptBT_CNBqLw@mail.gmail.com>
References: <CAKFQuwY=WLF0OH8JE5T8S=aj0LBydiSn02fkRE73Sm_KSLRqJQ@mail.gmail.com>
	<[email protected]>
	<CAKFQuwb3dG_tLFbWc_A_NMu-1b7xfGhPBa=dnAGptBT_CNBqLw@mail.gmail.com>

Few comments:

1)
+        Running read-only queries on a standby server.

Looks incomplete and disconnected from previous sentence.

2)
+        level used by the system.  Namely, whether replica has been promoted to
+        logical (minimal never promotes).

We shall replace replica, logical, minimal with below
<literal>replica</literal>
<literal>logical</literal>
<literal>minimal</literal>

Also shall we add 'wal_level'? Otherwise, 'replica' on its own could
be understood as a replica server:

Namely, whether wal_level replica has been promoted to ....

3)
+        The <xref linkend="guc-effective-wal-level"/> parameter
reports the actual
+        level used by the system.  Namely, whether replica has been promoted to
+        logical (minimal never promotes).
+        This parameter can only be set at server start.

"This" here is misleading. Does this refer to wal_level or effective_wal_level?

4)
Below that is <literal>minimal</literal>,

Shall we change "that" to <literal>replica</literal> to avoid any confusion?

thanks
Shveta

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: doc: Improve wal_level and effective_wal_level GUC around logical replication
  In-Reply-To: <CAJpy0uAv36NnfLH=t+XUbwF+o1DYvF4P+cFbwh9R2DvmRW7nQg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox