public inbox for [email protected]  
help / color / mirror / Atom feed
From: Greg Sabino Mullane <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: David Christensen <[email protected]>
Cc: Jim Jones <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Adding comments to help understand psql hidden queries
Date: Fri, 22 Mar 2024 10:46:48 -0400
Message-ID: <CAKAnmmL6-U+QPsuWM0r8mNq0Lo80d8L=cR7JLk7pypXJfwt=EA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAKAnmmJz8Hh=8Ru8jgzySPWmLBhnv4=oc_0KRiz-UORJ0Dex+w@mail.gmail.com>
	<CAHM0NXiD15-23=r1B9rHzKhS8e0+zwp_a6PncdLNetyF0xpNpA@mail.gmail.com>
	<[email protected]>
	<CAHM0NXheC3YO=ANPX0fCZKcQxMVBdgDzk9fc=-4TTCUN0aLYWA@mail.gmail.com>
	<[email protected]>

On Thu, Mar 21, 2024 at 6:20 PM Peter Eisentraut <[email protected]>
wrote:

> lines are supposed to align vertically.  With your patch, the first line
> would have variable length depending on the command.
>

Yes, that is a good point. Aligning those would be quite tricky, what if we
just kept a standard width for the closing query? Probably the 24 stars we
currently have to match "QUERY", which it appears nobody has changed for
translation purposes yet anyway. (If I am reading the code correctly, it
would be up to the translators to maintain the vertical alignment).

Cheers,
Greg


view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Adding comments to help understand psql hidden queries
  In-Reply-To: <CAKAnmmL6-U+QPsuWM0r8mNq0Lo80d8L=cR7JLk7pypXJfwt=EA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox