public inbox for [email protected]
help / color / mirror / Atom feedFrom: Greg Sabino Mullane <[email protected]>
To: Chao Li <[email protected]>
Cc: Jim Jones <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
Date: Wed, 11 Mar 2026 12:39:19 -0400
Message-ID: <CAKAnmmLWdEvFR+-+5HXzMEnd8fLfyvkK4QxtSHMBhoXC5Qvcug@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEoWx2=SLga-xH09Cq_PAvsHhQHrBK+V0vF821JKgzS=Bm0haA@mail.gmail.com>
<CAKFQuwZXt2dAuHFs6MtRCzfMP6YZFzssuzdW2woJBVmco=CDdQ@mail.gmail.com>
<CAEoWx2nic2MaPUEKwb0Me1iwO3LsCf8wUHm55pjqaTRgJEZpcQ@mail.gmail.com>
<CAKFQuwahxpPKT-LXGJ34BO5cVBUxFxzgNPTY8E_VW-cuNU_DkQ@mail.gmail.com>
<CAEoWx2kQ9aSn-0LGPKc=woj+h-HR4uBV9TL20aeM3HzLmFqgFQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAEoWx2mZsWnyS_XLDL5mL+yuU_g65p_tmHNesyfngqow7gtS3A@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAKAnmmKzzOWKQVhaAt8LrBmUW=FLWBqS4v8cwKOG53hBToQZRA@mail.gmail.com>
<[email protected]>
On Wed, Mar 11, 2026 at 3:05 AM Chao Li <[email protected]> wrote:
> Are you concerning that rendering the full message text is the extra work?
> This is not a hot path, so I don’t think that would be a big deal.
> Actually, adding two more fields sounds more expensive
Well, the recurring creation and freeing of the strings is the part that
seems inefficient. But you don't even need to store the strings at all if
you are tracking the action+rel. In such a case, the final strings can be
created on the fly inside of EmitPartitionNoRecurseNotice, right? Then you
just need a list to store the combos of action+relation.
Yes, as SET SCHEMA doesn’t go through the standard ALTER TABLE process:
> AlterTable() -> ATController() -> ATPrepCmd().
>
> If you get some idea, please let me know.
>
Nothing worth the trouble, to be honest. As you rightly pointed out, this
is not a hot path.
Cheers,
Greg
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
In-Reply-To: <CAKAnmmLWdEvFR+-+5HXzMEnd8fLfyvkK4QxtSHMBhoXC5Qvcug@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox