public inbox for [email protected]
help / color / mirror / Atom feedFrom: David G. Johnston <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: pg_recvlogical requires -d but not described on the documentation
Date: Mon, 17 Mar 2025 23:10:52 -0700
Message-ID: <CAKFQuwYoBUEYV218EYZeVn7S7S=kdoydw2PnAWszk0aTeS+k6A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <OSCPR01MB14966930B4357BAE8C9D68A8AF5C72@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAExHW5uOprZgj2rVQ0HT3ckr+fVvhG-DvcVT+wfmwnwynH00pw@mail.gmail.com>
<OSCPR01MB149660D1F436F8B82912FCB53F5C72@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAExHW5v94uRcr4f3+yhLrLX8UeYusJB06mcSqfdvu8fYUmVc=Q@mail.gmail.com>
<OS7PR01MB14968CC4F20B99B8E1508CE81F5C32@OS7PR01MB14968.jpnprd01.prod.outlook.com>
<CAKFQuwYWVT84GM2OqRx8EqNrfzNM-zbpQ5Y2bA1dPO9jUgo_Kg@mail.gmail.com>
<[email protected]>
On Monday, March 17, 2025, Fujii Masao <[email protected]> wrote:
>
> On 2025/03/12 14:59, David G. Johnston wrote:
>
>> On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) <
>> [email protected] <mailto:[email protected]>> wrote:
>>
>>
>> OK, so I will exclude the point in the thread. The patch I've posted
>> contains all of fixes
>> which is required.
>>
>>
>> The patch fixes the synopsis and the mention of the default value. Only
>> the later is required. I cannot figure out a policy that would alter the
>> synopsis in the proposed manner. I’d suggest leaving it alone for now and
>> tweak any of the option descriptions that may need clarification.
>>
>
> I agree that the synopsis doesn't need to be updated. Attached patch
> clarifies
> the required options for each action in the documentation. Thought?
Will look again tomorrow but seems ok aside from needing an editing pass.
The usage section for help probably needs a look as well.
>
> BTW, I'm curious why --dbname isn't required for the --drop-slot action.
> When I ran
> pg_recvlogical --drop-slot without --dbname, I got the following error:
>
> pg_recvlogical: error: could not establish database-specific replication
> connection
>
That would be a bug.
I think this is too:
set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_basebackup"));
Though I’m not sure what it is doing.
David J.
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pg_recvlogical requires -d but not described on the documentation
In-Reply-To: <CAKFQuwYoBUEYV218EYZeVn7S7S=kdoydw2PnAWszk0aTeS+k6A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox