public inbox for [email protected]
help / color / mirror / Atom feedFrom: David G. Johnston <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: describe special values in GUC descriptions more consistently
Date: Thu, 13 Feb 2025 15:50:08 -0700
Message-ID: <CAKFQuwYx_=44pZ1Pp-3fRFHt36G02Ldq2Db-phtD+EXLJ7VEFA@mail.gmail.com> (raw)
In-Reply-To: <Z65vw3mBv8wa7Wfj@nathan>
References: <Z6p8xOfmPUdo6QmI@nathan>
<CAHut+Pvx599kYqZaadZuVAtiqnfZDwgRUBzM7pnzEZjSSPEpCA@mail.gmail.com>
<CAKFQuwbRgfvTQYVifD+idSwi6fQT-mXSNrZmfC+2Z90R3toMKA@mail.gmail.com>
<Z6uS0l2g54hCQfBW@nathan>
<[email protected]>
<Z6vVfACwbkxqFSCX@nathan>
<Z60M1AmVLCODshn8@nathan>
<CAHut+PtanfZy6gpRoSBEjsxKRc57v7zoz8oADFHpz_joknYRfA@mail.gmail.com>
<Z60k4qYL7mtPtB3O@nathan>
<CAKFQuwbEzaX7Ssw4=ZLkdRG7142MpYNkDGZmMN=RmQXLreB3Tg@mail.gmail.com>
<Z65vw3mBv8wa7Wfj@nathan>
On Thu, Feb 13, 2025 at 3:18 PM Nathan Bossart <[email protected]>
wrote:
> On Wed, Feb 12, 2025 at 04:10:53PM -0700, David G. Johnston wrote:
> > I presume it doesn't affect the actual output which just concatenates the
> > fragments together but the source placement probably should be made
> > consistent; the line containing the initial default value specification
> > begins its own quoted fragment. The following violate that convention.
>
> Eh, most of the other descriptions with multiple sentences don't do that,
>
Apples and oranges.
so IMHO there's no need for the special values to go in their own fragment.
>
The examples shown look sloppy, IMHO; standing out since the other 50,
mostly due to the defaults being the only sentence in the gettext_noop, do
line up nicely with either a number or "The empty string" as the lead.
the worst offender is:
- "lost before a connection is considered dead. A value of 0 uses the "
- "system default."),
+ "lost before a connection is considered dead. 0 "
+ "means use the system default."),
Even if the diff has logic to it - only remove stuff from the first line,
only add stuff to the second, it isn't a big enough gain to offset leaving
the source ugly, IMHO.
David J.
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: describe special values in GUC descriptions more consistently
In-Reply-To: <CAKFQuwYx_=44pZ1Pp-3fRFHt36G02Ldq2Db-phtD+EXLJ7VEFA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox