pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: describe special values in GUC descriptions more consistently
Date: Tue, 11 Feb 2025 16:55:56 -0600
Message-ID: <Z6vVfACwbkxqFSCX@nathan> (raw)
In-Reply-To: <96FFD091-F221-4009-AA34-C740AC3C330D@yesql.se>
References: <Z6aIy4aywxUZHAo6@nathan>
	<CAHut+Ptw+z=uXpGLQU3rXNUhyz3hiBDZD9_d-L0jE0yvboqmFQ@mail.gmail.com>
	<Z6ojAoZPfjGo0qP8@nathan>
	<CAKFQuwZmvTyqm_j8qPS6nVx6CLObc1oOrv8RzOBZie26oYO2_Q@mail.gmail.com>
	<CAHut+PsD2pz98X6MEApF9rZnkg4w_FCgVd+=npDvSw3+BWVHnA@mail.gmail.com>
	<Z6p8xOfmPUdo6QmI@nathan>
	<CAHut+Pvx599kYqZaadZuVAtiqnfZDwgRUBzM7pnzEZjSSPEpCA@mail.gmail.com>
	<CAKFQuwbRgfvTQYVifD+idSwi6fQT-mXSNrZmfC+2Z90R3toMKA@mail.gmail.com>
	<Z6uS0l2g54hCQfBW@nathan>
	<96FFD091-F221-4009-AA34-C740AC3C330D@yesql.se>

On Tue, Feb 11, 2025 at 11:41:51PM +0100, Daniel Gustafsson wrote:
>> On 11 Feb 2025, at 19:11, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
>> I thought about this one a bit, and I actually came to the opposite
>> conclusion.  IMHO it's reasonably obvious that an empty string means that
>> the file isn't loaded, so there's not much point in stating it in the GUC
>> description.  Instead, I think we should follow the
>> archive_command/archive_library example and use this space _only_ as a
>> cross-reference to each other.  There's certainly some nuances missed with
>> this strategy, but that's not unique to this GUC.
> 
> I don't necessarily disagree with this, but the proposed wording makes it sound
> sort of like users have to select one or the other.  Could it be softened a
> little like perhaps "An empty string disables, \"ssl_crl_foo\" is still used"?

Hm.  I'm starting to lean towards considering these as too complicated to
include in the GUC description.

-- 
nathan





view thread (27+ messages)  latest in thread

Message-ID: <Z6vVfACwbkxqFSCX@nathan>
Permalink:  ../Z6vVfACwbkxqFSCX@nathan/
Also on:    postgresql.org/message-id/Z6vVfACwbkxqFSCX@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, daniel@yesql.se, david.g.johnston@gmail.com, smithpb2250@gmail.com
  Subject: Re: describe special values in GUC descriptions more consistently
  In-Reply-To: <Z6vVfACwbkxqFSCX@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox