public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G. Johnston <[email protected]>
To: David Rowley <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: EXPLAIN IndexOnlyScan shows disabled when enable_indexonlyscan=on
Date: Mon, 28 Oct 2024 18:40:50 -0700
Message-ID: <CAKFQuwa6M_Hd0LX2xi3SPUvXaAqKCpn8Tnj6F=-jJZ9Avh0Chw@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvrR=0ExMOEQvnwWfck2NSk=_pktwNDvybYS-ziB74kT1w@mail.gmail.com>
References: <CAAKRu_atV=kovgpaLREyG68PB5+ncKvJ2UNoeRetEgyC3Yb5Sw@mail.gmail.com>
	<CAApHDvqAY6OVVPSRqGkcPExRKutCGzZPbhWm0EkORWGqLBWVxQ@mail.gmail.com>
	<CAKFQuwYx0m2O3rM=CF1nj6xuqNMTe-NPNOsue7chyqS_EjhKng@mail.gmail.com>
	<CAApHDvr_Ncavgr7z4xmXuStWCaQoE0=z2kZj6JiFku8DB1iBfw@mail.gmail.com>
	<CAKFQuwbNOj4f6ar1+jkBFGhK+t6fNwzM0ygLh7GBFSxVGSO8TQ@mail.gmail.com>
	<CAApHDvrR=0ExMOEQvnwWfck2NSk=_pktwNDvybYS-ziB74kT1w@mail.gmail.com>

On Mon, Oct 28, 2024 at 3:54 PM David Rowley <[email protected]> wrote:

>
> I've attached that in patch form.
>
>
 -        Enables or disables the query planner's use of index-scan plan
-        types. The default is <literal>on</literal>.
+        Enables or disables the query planner's use of index-scan and
+        index-only-scan plan types.  The default is <literal>on</literal>.
+        Also see <xref linkend="guc-enable-indexonlyscan"/>.

I think the original wording "index-scan plan types" is what is confusing
me.  The plural types is turning index-scan plan into a category of plans
rather than the single plan type "index scan".

Your proposed wording actually (accidentally?) fixes this because now the
plural types actually refers to two individual plan nodes, "index scan" and
"index-only scan".

The hyphenation still reads a bit odd but ok.

I am ok with this revision (and the patch as a whole) I suppose but I still
feel like something is missing here.  Though probably that something would
fit better in an overview page rather than trying to get the settings to
explain all this to the reader.

David J.

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: EXPLAIN IndexOnlyScan shows disabled when enable_indexonlyscan=on
  In-Reply-To: <CAKFQuwa6M_Hd0LX2xi3SPUvXaAqKCpn8Tnj6F=-jJZ9Avh0Chw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox