public inbox for [email protected]
help / color / mirror / Atom feedFrom: Mahendra Singh Thalor <[email protected]>
To: Andrew Dunstan <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: pg_restore: remove unnecessary code from restore_all_databases function
Date: Sun, 15 Mar 2026 23:03:34 +0530
Message-ID: <CAKYtNAoVD2FYpnGYMLiQ3+Br4XZwCyStxxQgx8FWW4OSWBeZDg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAKYtNAqN49Hqd4v0wWH3uW6d6QsH+8e8bR_MVf4CboTZSzd+Aw@mail.gmail.com>
<[email protected]>
On Sun, 15 Mar 2026 at 21:46, Andrew Dunstan <[email protected]> wrote:
>
>
> On 2026-03-14 Sa 11:48 PM, Mahendra Singh Thalor wrote:
> > Hi hackers,
> >
> > +++ b/src/bin/pg_dump/pg_restore.c
> > @@ -1268,16 +1268,6 @@ restore_all_databases(const char *inputFileSpec,
> > */
> > memcpy(tmpopts, original_opts, sizeof(RestoreOptions));
> >
> > - /*
> > - * We need to reset override_dbname so that objects
> > can be restored
> > - * into an already created database. (used with
> > -d/--dbname option)
> > - */
> > - if (tmpopts->cparams.override_dbname)
> > - {
> > - pfree(tmpopts->cparams.override_dbname);
> > - tmpopts->cparams.override_dbname = NULL;
> > - }
> > -
> >
> > In commit 77152d26efefde2eed4, we added some functions and we missed
> > to remove some unnecessary lines. Those lines are not needed as we are
> > using memcpy to get the original copy before these lines.
> >
> > Here, I am attaching a patch to fix this. Please review it.
>
>
> Thanks. Pushed.
>
>
> cheers
>
>
> andrew
>
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>
Thanks Andrew for committing this.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pg_restore: remove unnecessary code from restore_all_databases function
In-Reply-To: <CAKYtNAoVD2FYpnGYMLiQ3+Br4XZwCyStxxQgx8FWW4OSWBeZDg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox