public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jakub Wartak <[email protected]>
To: Andres Freund <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Failing test_aio tests due to too low(illegal?) segsize_blocks
Date: Thu, 9 Apr 2026 10:35:48 +0200
Message-ID: <CAKZiRmxUgcx6gY0kBSq8Y+RzACpknns6gkDt-OO1skr5H7ZAYQ@mail.gmail.com> (raw)
In-Reply-To: <ym373n5ssebp64n7kwk4cwx2d5epwbabm76pdrk3gat63fxwbd@knjuyj6coe27>
References: <CAKZiRmz=YYQU5Gzq-bVjiwMfmVmxrewWaJVducSO3g4iWvBkFg@mail.gmail.com>
	<ym373n5ssebp64n7kwk4cwx2d5epwbabm76pdrk3gat63fxwbd@knjuyj6coe27>

On Wed, Apr 8, 2026 at 8:57 PM Andres Freund <[email protected]> wrote:
>
> Hi,
>
> On 2026-04-08 08:51:30 +0200, Jakub Wartak wrote:
> > For some reason I've ended up using -Dsegsize_blocks=4 and I've started
> > getting ninja test errors after getting back from vacation leave like
> > below (so this test was included only since then):
>
> It's IIRC not the only test that fails if you do that.
>
>
> > .cirrus file show usage of segsize_blocks=6, and also 8 works fine without
> > errors, so it's just nuisance on my side, but it took some minutes for me
> > to realize this and I'll just ask maybe we should just block usage of
> > RELSEG_SIZE < 6 blocks in meson/configure? (patch attached)
>
> -1.  I find it quite useful for testing some edge cases to be able to
> configure with less.
>
> If you really care, I'd be ok with a patch that makes the relevant test_aio
> tests errors out with if it's set to a too low value...

Ah, true, with segsize_blocks=2 I've got failures in basebackup,
amcheck, test_aio.
I'm not going into that dragons' den. Ok, so maybe it would be useful to just
issue some sort of warning about that some test may fail when using value less
than 6?

-J.

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Failing test_aio tests due to too low(illegal?) segsize_blocks
  In-Reply-To: <CAKZiRmxUgcx6gY0kBSq8Y+RzACpknns6gkDt-OO1skr5H7ZAYQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox