public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yasuo Honda <[email protected]>
To: Dmitry Dolgov <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Gregory Stark (as CFM) <[email protected]>
Cc: David Geier <[email protected]>
Cc: Sergei Kornilov <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Marcos Pegoraro <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Zhihong Yu <[email protected]>
Cc: David Steele <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Pavel Trukhanov <[email protected]>
Subject: Re: pg_stat_statements and "IN" conditions
Date: Sun, 24 Mar 2024 23:36:38 +0900
Message-ID: <CAKmOUTn74jTQAk0u2FUMsGjgrNugLOwkyic2MPkbOJtcQrufeA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CALDaNm0Oov2Xbt8PLGOhFTLF7_uEWu6_pz2xHeEtQQiUx6nRiw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAHut+PuXZsPPJyUnYY7RHSM0vspM0z42KfsTvOetJNkuuDGZSQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAKmOUTnXgqSS0Q7mFaQZBNbXUM+FYz5FZsHc4ifK+SgScSgXAQ@mail.gmail.com>
	<[email protected]>

Thanks for the information. I can apply these 4 patches from
0eb23285a2 . I tested this branch from Ruby on Rails and it gets some
unexpected behavior from my point of view.
Setting pg_stat_statements.query_id_const_merge_threshold = 5 does not
normalize sql queries whose number of in clauses exceeds 5.

Here are test steps.
https://gist.github.com/yahonda/825ffccc4dcb58aa60e12ce33d25cd45#expected-behavior

It would be appreciated if I can get my understanding correct.
--
Yasuo Honda

On Sun, Mar 24, 2024 at 3:20 AM Dmitry Dolgov <[email protected]> wrote:

> Sure, I can rebase, give me a moment. If you don't want to wait, there
> is a base commit in the patch, against which it should be applied
> without issues, 0eb23285a2.

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg_stat_statements and "IN" conditions
  In-Reply-To: <CAKmOUTn74jTQAk0u2FUMsGjgrNugLOwkyic2MPkbOJtcQrufeA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox