public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dapeng Wang <[email protected]>
To: David G. Johnston <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Docs: Create table description for constraints markup fix and label tweaks
Date: Fri, 10 Apr 2026 15:42:02 +0800
Message-ID: <CAKx0YhzeEZKKgqn5_yBr5L7UxAf31Acw45PmSA6MsvVnw8vDeQ@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwYda2RwHdzwbz3FcMs_2kaKn7skpuPzAd15h5DH1LfzQg@mail.gmail.com>
References: <CAKFQuwbsGWx5msYbRsWrRs+ss1k0utDHEhVq5unAKODQ9YOf9w@mail.gmail.com>
	<CAKFQuwYda2RwHdzwbz3FcMs_2kaKn7skpuPzAd15h5DH1LfzQg@mail.gmail.com>

Hi David,

I reviewed both patches on the latest HEAD.

0001: SGML nesting fix applied and verified - make html
builds successfully with the corrected element nesting
for UNIQUE and PRIMARY KEY.

0002: The six "variant" label changes look good and should
help avoid the confusion reported on -general.

Looks good to me.

Regards,
Dapeng Wang

David G. Johnston <[email protected]> 于2026年4月10日周五 15:04写道：

> On Fri, Apr 3, 2026 at 10:18 AM David G. Johnston <
> [email protected]> wrote:
>
>> Responding to a recent report on -general [1] I found a markup bug in the
>> primary key description under create table.  0001 fixes this.
>>
>> The complaint itself was about using "column constraint" as a descriptive
>> label in a syntax area when "column constraint" is an actual defined syntax
>> label.  0002 adds the word "variant" to the six places "(table/column
>> constraint)" is used in this manner.
>>
>> [1]
>> https://www.postgresql.org/message-id/[email protected]...
>>
>>
> The more you look (not having production dark mode in the core build is a
> bit annoying)...v2 attached after re-reading the original thread and
> looking around a bit more.
>
> Unique had the same sgml markup error as primary key.
>
> Also, the CF entry: https://commitfest.postgresql.org/patch/6648/
>
> David J.
>
> P.S. Reviewing this we are inconsistent as to where we use "optional"
> markup versus just literal [ ].  Even among these three locations there are
> variances - and simply literals used for optional meaning brackets.
>
>

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Docs: Create table description for constraints markup fix and label tweaks
  In-Reply-To: <CAKx0YhzeEZKKgqn5_yBr5L7UxAf31Acw45PmSA6MsvVnw8vDeQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox