public inbox for [email protected]  

help / color / mirror / Atom feed

From: Roberto Mello <[email protected]>
To: Ajin Cherian <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_publication_tables: return NULL attnames when no column list is specified
Date: Fri, 27 Mar 2026 11:27:16 -0600
Message-ID: <CAKz==bLYWG43n6J0Ze1Y5fgyrW32_73WQkNSPbWGmFwLE8Aa0A@mail.gmail.com> (raw)
In-Reply-To: <CAFPTHDa-k7qV=H_UgojLs-denk8upJWG7s6xZwD4r4ZTP-=q5Q@mail.gmail.com>
References: <CAKz==b+k7OwOib__LgfDadUzW9jFrbQ9FqdERpsufi8d7F=vkQ@mail.gmail.com>
	<CAHut+PuhDwEySMSMz_4hgmFNG75Wx=Wv4guuaUSGi6e3ixsUUw@mail.gmail.com>
	<CAKz==bLEjr+706MkmpHsd1wfz0EqYzEXJVb2cn2mxp2nnHf=kQ@mail.gmail.com>
	<CAFPTHDa-k7qV=H_UgojLs-denk8upJWG7s6xZwD4r4ZTP-=q5Q@mail.gmail.com>

On Thu, Mar 26, 2026 at 10:07 PM Ajin Cherian <[email protected]> wrote:

>
> Tested the patch and the patch fixes the bug as described. My tests below:
>

Thank you for the review.

<snip>

One observation from reviewing the patch: the test suite covers the
> partial column list and dropped column cases well, but is missing a
> test for the two-publication conflict scenario (one pub with no list +
> one pub with an explicit list of all columns on the same table). That
> is the breaking change called out in the original report and probably
> deserves its own regression test with a comment explaining the
> expected behavior change for users in that configuration.
> Patch LGTM otherwise.
>

Good point. I know I worked on that, so I must have accidentally dropped it
from the patch.

Will prepare a revision and submit.

Thanks again.

Roberto Mello
Snowflake

P.S.: I forgot to acknowledge and thank Greg Mullane for the initial review
on the patch, so doing that now.

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pg_publication_tables: return NULL attnames when no column list is specified
  In-Reply-To: <CAKz==bLYWG43n6J0Ze1Y5fgyrW32_73WQkNSPbWGmFwLE8Aa0A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox