public inbox for [email protected]
help / color / mirror / Atom feedFrom: vignesh C <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Tristan Partin <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix publisher-side sequence permission reporting
Date: Mon, 29 Jun 2026 21:31:14 +0530
Message-ID: <CALDaNm1DWVcFA10ULBaBVJg7sAGnDHOzDbAmFGTWj5mEQ3bPUw@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwE9AOvhqPOx7J=zPug5s90FhNVPH8m0m3AVJVzjG8npBQ@mail.gmail.com>
References: <CAHGQGwGNTaXnBKUV510_P1KwhdbHT+kgZ4zU5njBHy7nCqdhzg@mail.gmail.com>
<[email protected]>
<CAHGQGwE95GLD7RZr2g=zTHKJRafKACmKouhb4TTVH155Hy8zKA@mail.gmail.com>
<[email protected]>
<CAHGQGwFLXCAxKEyvvaTLadHZ8k4DFmjJopnN+Vy-NjtfKoM7dw@mail.gmail.com>
<CAA4eK1JOo0aJRhFHNWpj3hMwaTtNOopY34f1Lh_QD=z=+DrzWQ@mail.gmail.com>
<CAHGQGwEA6PMAE0aMx4MFqj9d+q2Q835gfUyTSJjAkoMwtWB77A@mail.gmail.com>
<CAA4eK1+C+mG6ihu_Cs3KjMw9DJgUneSXy5k0HsXyoE1EeWQ1gQ@mail.gmail.com>
<CAHGQGwHuuffj_js4n2g2M07vpkbun8Aj_4+o4ALK=rQpBfwk7w@mail.gmail.com>
<CAA4eK1+UU-MLCWiO0Yf8WPakt6tSK2YsFDCQnzt6616+jy2CRw@mail.gmail.com>
<CAHGQGwH1Ssze3XM6wjoTjSLVOR041c6xP+vsdLP951=w8oG8bA@mail.gmail.com>
<CAHGQGwEcGpnHWw1uwsWkgVwKv5cwysKfir2yXDQnN1aVOAhCdQ@mail.gmail.com>
<CALDaNm2o9o-QOArgO3Dmz-Kb_goRzNse41G4CQh8SgJWrU2WLQ@mail.gmail.com>
<CAHGQGwE9AOvhqPOx7J=zPug5s90FhNVPH8m0m3AVJVzjG8npBQ@mail.gmail.com>
On Fri, 26 Jun 2026 at 12:34, Fujii Masao <[email protected]> wrote:
>
> On Wed, Jun 24, 2026 at 7:49 PM vignesh C <[email protected]> wrote:
> > Thanks for the patch. I verified that it fixes the issue with reading
> > unlogged sequences on a promoted standby.
>
> Thanks for testing!
>
>
> > Do you think it would be worthwhile to add a test for this scenario,
> > or do you feel the additional test is not necessary in this case?
>
> I think it's worth adding a test for this scenario, so I've added one to
> the patch. The test uses nextval() to read the unlogged sequence
> instead of pg_get_sequence_data(), since this patch needs to be
> backpatched to v15, while pg_get_sequence_data() was introduced in
> v19.
Thanks for the updated patches. I verified that the issue occurs with
nextval() on all supported branches up to v15, where unlogged
sequences are available. The corresponding back patches apply cleanly
to their respective branches and fix the issue. I also checked other
unlogged objects but couldn't reproduce a similar issue with them.
Overall, the patches look good to me.
Regards,
Vignesh
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fix publisher-side sequence permission reporting
In-Reply-To: <CALDaNm1DWVcFA10ULBaBVJg7sAGnDHOzDbAmFGTWj5mEQ3bPUw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox