public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tristan Partin <[email protected]>
To: Fujii Masao <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix publisher-side sequence permission reporting
Date: Fri, 19 Jun 2026 16:38:27 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwE95GLD7RZr2g=zTHKJRafKACmKouhb4TTVH155Hy8zKA@mail.gmail.com>
References: <CAHGQGwGNTaXnBKUV510_P1KwhdbHT+kgZ4zU5njBHy7nCqdhzg@mail.gmail.com>
	<[email protected]>
	<CAHGQGwE95GLD7RZr2g=zTHKJRafKACmKouhb4TTVH155Hy8zKA@mail.gmail.com>

On Fri Jun 19, 2026 at 9:16 AM CDT, Fujii Masao wrote:
> On Fri, Jun 19, 2026 at 8:11 AM Tristan Partin <[email protected]> wrote:
>> The patch looks good to me! I had one suggestion:
>>
>> >  ##########
>> >  # Ensure that insufficient privileges on the publisher for a sequence do not
>> > -# disrupt the subscriber. The subscriber should log a warning and continue
>> > -# retrying.
>> > +# get misreported as a missing sequence. The subscriber should log a warning
>> > +# and continue retrying.
>> >  ##########
>>
>> I think a better comment might be:
>>
>>         Ensure that insufficient privileges on the publisher for a sequence
>>         are reported correctly...
>>
>> My reasoning for suggesting that is because your comment would to
>> indicate that any warning is accurate as long as it isn't related to
>> a missing sequence.
>
> Thanks for the review! I've updated the patch as suggested.
>
> Updated patches attached.

Looks great! Thanks for fixing this.

-- 
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix publisher-side sequence permission reporting
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox