public inbox for [email protected]  

help / color / mirror / Atom feed

From: vignesh C <[email protected]>
To: Shubham Khanna <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Nisha Moond <[email protected]>
Cc: Shlok Kyal <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Amit Kapila <[email protected]>
Subject: Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Date: Thu, 20 Mar 2025 09:37:04 +0530
Message-ID: <CALDaNm3pX+C61UDnN76sz+-irHdu03RTmBDCQb8fzVFu30CFkA@mail.gmail.com> (raw)
In-Reply-To: <CAHv8RjLqk07qQU_FNuyWSRCena_YYySGR6vNFAQ0kDTLmmq8Mg@mail.gmail.com>
References: <CAA4eK1LT=03FUoLew8qvTay+xzmvO-gAMsh+kvMBVd6+yqi3kQ@mail.gmail.com>
	<CAHv8RjJNE1ZvWhsgL54iPsJhomhcG+-SGPN8AnnwdLmWt6A44A@mail.gmail.com>
	<OSCPR01MB14966D341D7E689DA6B78CAC4F5D92@OSCPR01MB14966.jpnprd01.prod.outlook.com>
	<CAHv8RjKbYaCRrzJzmU6gU0jt85xJftzVV-Hu9rXrkb1yFzYTtA@mail.gmail.com>
	<CALDaNm3wLKFjSJ-4fF4ACBaq+jH3fPeA68OmS3jc_smaOe=6Qw@mail.gmail.com>
	<CAHv8RjLqk07qQU_FNuyWSRCena_YYySGR6vNFAQ0kDTLmmq8Mg@mail.gmail.com>

On Thu, 20 Mar 2025 at 09:06, Shubham Khanna
<[email protected]> wrote:
>
> The attached patch contains the suggested changes.

Couple of minor comments:
1) The second and third line comments can be in same line:
+# Create user-defined publications, wait for streaming replication to sync them
+# to the standby, then verify that '--remove'
+# removes them.

2) This comment can be in a single line:
+# In passing, also test the --enable-two-phase option and
+# --remove option

Regards,
Vignesh

view thread (86+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
  In-Reply-To: <CALDaNm3pX+C61UDnN76sz+-irHdu03RTmBDCQb8fzVFu30CFkA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox