public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kirill Reshke <[email protected]>
To: Japin Li <[email protected]>
Cc: Shinya Kato <[email protected]>
Cc: jian he <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: remove unnecessary include in src/backend/commands/policy.c
Date: Sun, 4 Jan 2026 00:47:23 +0500
Message-ID: <CALdSSPj7U-eqAQb2XOBEQfoJFsnMQHa=MwcMEpiEkNUrhDoCUg@mail.gmail.com> (raw)
In-Reply-To: <MEAPR01MB3031B77A2590351DC563605DB6B0A@MEAPR01MB3031.ausprd01.prod.outlook.com>
References: <CAOzEurQ9kYGd50j4O2RVT2FrLhESDCz8f+P+0y3eS1uYCJmSSg@mail.gmail.com>
<[email protected]>
<CAOzEurRgM_JyYqOxEfBU6t6y7YNT6fzGvM9BvN8=jtiZOJ+iYA@mail.gmail.com>
<CACJufxGTJrH6ZSpMMBOpAPhPy_Uirz7wpqgO8_Yki_rGqWviHw@mail.gmail.com>
<CAOzEurR27z9-4-5J0Tv27+c+Y37uY8ZS2g-ttcs0fYaa2CVAUw@mail.gmail.com>
<CAOzEurQFPH+UNk17MbDhupLCm-i5Gf9dJ4Kx2-er=-YYV4r+sQ@mail.gmail.com>
<MEAPR01MB3031B77A2590351DC563605DB6B0A@MEAPR01MB3031.ausprd01.prod.outlook.com>
On Fri, 26 Dec 2025 at 14:29, Japin Li <[email protected]> wrote:
>
>
> Hi, Shinya
>
> On Fri, 26 Dec 2025 at 16:30, Shinya Kato <[email protected]> wrote:
> > On Wed, Oct 22, 2025 at 3:30 PM Shinya Kato <[email protected]> wrote:
> >> Thank you for updating the patch.
> >> But I said "except for access/relation.h". I think access/relation.h
> >> is not necessary if you replace relation_open to table_open.
> >
> > I've fixed it, and marked the patch as Ready for Committer.
> >
>
> Found a typo in the commit message.
>
> > RangeVarCallbackForPolicy already ensures policies apply only to tables
> > or partitioned tables, so table_* isthe appropriate API for
> > opening/closing the target relation.
>
> s/isthe/is the/
>
>
> --
> Regards,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>
>
Hi hackers!
We also can reflect that our new coding practice is to use table/index
open over relation_open in the commit message (I guess so after[0]).
Overall LGTM.
[0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=9d0f7996e58c2a92efe06c901c6dfe1f6ced0a1d
--
Best regards,
Kirill Reshke
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: remove unnecessary include in src/backend/commands/policy.c
In-Reply-To: <CALdSSPj7U-eqAQb2XOBEQfoJFsnMQHa=MwcMEpiEkNUrhDoCUg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox