public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kirill Reshke <[email protected]>
To: Paul A Jungwirth <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: SQL:2011 Application Time Update & Delete
Date: Tue, 10 Mar 2026 22:33:30 +0500
Message-ID: <CALdSSPj7mp4V4sJeqd2si1fZiwwECPDchqqNtBN6EOTkb3bvEg@mail.gmail.com> (raw)
In-Reply-To: <CA+renyXUy6W4xqS5Mi2e0D_PF1ZVTw5jacd0tAOboyg5e5DNTQ@mail.gmail.com>
References: <[email protected]>
	<CA+renyW7ZB_k9AgmSFJU2EegL9r1k1sgWo4-9tGGkgwxNqe6kw@mail.gmail.com>
	<CA+renyUodzxAvMnpa_LTvo+Ru1ZKH+Su8KaPvD4iMtguFKzq4g@mail.gmail.com>
	<[email protected]>
	<CA+renyU-iz_zvM0gGP=dvBPVrz=Jj3qdCjtAh5nLZRhb49xMFw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+renyXchHgpMbYX-cR8fuNnnpf_+FJ6PkHoXoa2AgzRnz4vxQ@mail.gmail.com>
	<[email protected]>
	<CA+renyXH3AF6JVzZGVcT5mAo=0QncB-MpWJeqb2JG66sgyq09g@mail.gmail.com>
	<[email protected]>
	<CA+renyUazgR-hB_6RY60n23L0y-n_h9G1AappZmPENO0k5pL1g@mail.gmail.com>
	<[email protected]>
	<CA+renyVXg5pV84wQnGQuK8-=qoKw3BiBgQzesxM_LkcxxWmYjA@mail.gmail.com>
	<[email protected]>
	<CA+renyWKOj5=rMmQmJcbybu-Vdomxdp=eJ93kp76AgmQKYdfiQ@mail.gmail.com>
	<[email protected]>
	<CA+renyUhuXB2nTVCMREXew9E4DZOnFxQNjME5bcw91+k72Bosg@mail.gmail.com>
	<CA+renyWUCSyTMn3s03kviEN-oaVrJP-QkDQCLNfaY=MHV5QEiQ@mail.gmail.com>
	<CA+renyV4tWU2d=n9_v=XNPHbZfNqqLokzd-Xt78M-zLd+46ubA@mail.gmail.com>
	<CALdSSPjKLuqbLen2HSFs1Uef-hetVwZqqdZKPd45gfsVvHRhZA@mail.gmail.com>
	<CA+renyXUy6W4xqS5Mi2e0D_PF1ZVTw5jacd0tAOboyg5e5DNTQ@mail.gmail.com>

On Tue, 10 Mar 2026 at 21:13, Paul A Jungwirth
<[email protected]> wrote:
>
> On Tue, Mar 10, 2026 at 5:26 AM Kirill Reshke <[email protected]> wrote:
> > When applying first two of patches from v67 series, my initdb fails:
> >
> > ```
> > reshke@yezzey-cbdb-bench:~/cpg$ ./bin/bin/initdb -D ./db
> > The files belonging to this database system will be owned by user "reshke".
> > This user must also own the server process.
> >
> > The database cluster will be initialized with locale "C.UTF-8".
> > The default database encoding has accordingly been set to "UTF8".
> > The default text search configuration will be set to "english".
> >
> > Data page checksums are enabled.
> >
> > creating directory db ... ok
> > creating subdirectories ... ok
> > selecting dynamic shared memory implementation ... posix
> > selecting default "max_connections" ... 100
> > selecting default "shared_buffers" ... 128MB
> > selecting default time zone ... Etc/UTC
> > creating configuration files ... ok
> > running bootstrap script ... ok
> > performing post-bootstrap initialization ... 2026-03-10 12:21:05.842
> > UTC [2995664] WARNING:  unrecognized node type: 155
> > 2026-03-10 12:21:05.842 UTC [2995664] FATAL:  unrecognized node type: 155
> > 2026-03-10 12:21:05.842 UTC [2995664] STATEMENT:  REVOKE ALL ON
> > pg_authid FROM public;
> >
> > child process exited with exit code 1
> > initdb: removing data directory "db"
> > ```
> >
> > without v67-0002 initdb runs ok.
> >
> > Also, after v67-0002 my createdb fails:
> >
> > ```
> > reshke@yezzey-cbdb-bench:~/cpg$ ./bin/bin/createdb
> > createdb: error: query failed: ERROR:  syntax error at or near "("
> > LINE 1: SELECT pg_catalog.set_config('search_path', '', false);
> >                                     ^
> > createdb: detail: Query was: SELECT
> > pg_catalog.set_config('search_path', '', false);
> > ```
> >
> > Simple queries also fails:
> > ```
> > postgres=# select now();
> > WARNING:  unrecognized node type: 144
> > ERROR:  unrecognized node type: 76
> > ```
>
> I don't see any of these problems here (after an error-free rebase
> onto a198c26ded), and CI passes. Are you sure that was from a clean
> build? If so, could you share your configure line?
>
> Thanks,
>
> --
> Paul              ~{:-)
> [email protected]

Sorry, It was indeed an issue on my side. It all gone after make
maintainer-clean.
Anyway, I was interested in by-hand testing of 0001 & 0002, which I
did. I tested various partitioned table use-cases, including the new
MERGE PARTITIONS feature, updating the partition column, etc. All
seems to work just fine.

The only review comment I have is that we may need tab-completion
support for UPDATE ... [FOR PARTITION OF] pattern.

-- 
Best regards,
Kirill Reshke





view thread (54+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: SQL:2011 Application Time Update & Delete
  In-Reply-To: <CALdSSPj7mp4V4sJeqd2si1fZiwwECPDchqqNtBN6EOTkb3bvEg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox