public inbox for [email protected]
help / color / mirror / Atom feedFrom: Gregory Stark (as CFM) <[email protected]>
To: Sandro Santilli <[email protected]>
Cc: [email protected]
Cc: Regina Obe <[email protected]>
Subject: Re: Ability to reference other extensions by schema in extension scripts
Date: Mon, 6 Mar 2023 13:49:51 -0500
Message-ID: <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com> (raw)
In-Reply-To: <167762779361.628976.14009177203307564086.pgcf@coridan.postgresql.org>
References: <[email protected]>
<[email protected]>
<167762779361.628976.14009177203307564086.pgcf@coridan.postgresql.org>
It looks like this patch needs a quick rebase, there's a conflict in
the meson.build.
I'll leave the state since presumably this would be easy to resolve
but it would be more likely to get attention if it's actually building
cleanly.
http://cfbot.cputube.org/patch_42_4023.log
On Tue, 28 Feb 2023 at 18:44, Sandro Santilli <[email protected]> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, failed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> I've applied the patch attached to message https://www.postgresql.org/message-id/000401d94bc8%2448dff700%24da9fe500%24%40pcorp.us (md5sum a7d45a32c054919d94cd4a26d7d07c20) onto current tip of the master branch being 128dd9f9eca0b633b51ffcd5b0f798fbc48ec4c0
>
> The review written in https://www.postgresql.org/message-id/20230228224608.ak7br5shev4wic5a%40c19 all still applies.
>
> The `make installcheck-world` test fails for me but the failures seem unrelated to the patch (many occurrences of "+ERROR: function pg_input_error_info(unknown, unknown) does not exist" in the regression.diff).
>
> Documentation exists for the new feature
>
> The new status of this patch is: Ready for Committer
--
Gregory Stark
As Commitfest Manager
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Ability to reference other extensions by schema in extension scripts
In-Reply-To: <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox