public inbox for [email protected]
help / color / mirror / Atom feedFrom: Miłosz Bieniek <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
Date: Fri, 28 Nov 2025 13:58:01 +0100
Message-ID: <CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAMSWrt-PoQt4sHryWrB1ViuGBJF_PpbjoSGrWR2Ry47bHNLDqg@mail.gmail.com>
<[email protected]>
pt., 28 lis 2025 o 12:53 Peter Eisentraut <[email protected]> napisał(a):
>
> On 27.11.25 10:28, Miłosz Bieniek wrote:
> > While reviewing a patch I noticed that we have a `make -s headerscheck`
> > but there is no equivalent in meson.
> > I prepared a small patch that adds `headerscheck` and `cpluspluscheck`
> > targets.
>
> This would be good to have, but I don't think your patch works. It
> seems you need to add the srcdir and builddir command-line arguments to
> the invocations.
>
I think you are right. I added srcdir and builddir arguments.
Attachments:
[application/octet-stream] v2-0001-Add-headerscheck-run_target-to-meson.patch (1.1K, 2-v2-0001-Add-headerscheck-run_target-to-meson.patch)
download | inline diff:
From e81db5a0ecd699cd5c676b4c3e6f4cdd14f26b97 Mon Sep 17 00:00:00 2001
From: moozzi <[email protected]>
Date: Fri, 28 Nov 2025 13:54:13 +0100
Subject: [PATCH v2] Add `headerscheck` run_target to meson
---
meson.build | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/meson.build b/meson.build
index 6e7ddd74683..1f74750c914 100644
--- a/meson.build
+++ b/meson.build
@@ -3900,6 +3900,20 @@ endif
+###############################################################
+# headerscheck
+###############################################################
+
+run_target('headerscheck',
+ command: [meson.project_source_root() / 'src/tools/pginclude/headerscheck', meson.project_source_root(), meson.project_build_root()]
+)
+
+run_target('cpluspluscheck',
+ command: [meson.project_source_root() / 'src/tools/pginclude/headerscheck', '--cplusplus', meson.project_source_root(), meson.project_build_root()]
+)
+
+
+
###############################################################
# The End, The End, My Friend
###############################################################
--
2.49.0
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
In-Reply-To: <CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox