public inbox for [email protected]  

help / color / mirror / Atom feed
From: Richard Guo <[email protected]>
To: Masahiko Sawada <[email protected]>
Cc: Japin Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Date: Wed, 14 Jun 2023 15:38:10 +0800
Message-ID: <CAMbWs48KxbY9EzZSQBy-30Ey06H-+Bi4HcQvxrOvEHANSGQmVg@mail.gmail.com> (raw)
In-Reply-To: <CAD21AoAa4vTH0Up1QUdbpnROnrC3+iGe_LS4sG6XKwZT-o-Kpw@mail.gmail.com>
References: <MEYP282MB1669EC0FED922F7A151673ACB65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
	<CAD21AoAa4vTH0Up1QUdbpnROnrC3+iGe_LS4sG6XKwZT-o-Kpw@mail.gmail.com>

On Wed, Jun 14, 2023 at 1:07 PM Masahiko Sawada <[email protected]>
wrote:

> On Wed, Jun 14, 2023 at 12:33 PM Japin Li <[email protected]> wrote:
> > Hi, hackers
> >
> > We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even though
> we
> > already define it in guc.h.
> >
> > Maybe using GUC_UNIT is better?  Here is a patch to fix it.
>
> Yeah, it seems more consistent with other places in guc.c. I'll push
> it, barring any objections.


+1.  BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
GUC_UNIT.  I was wondering if we can retire it, but maybe we'd better
not.  It still indicates that we need to use time units table.

Thanks
Richard


view thread (6+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
  In-Reply-To: <CAMbWs48KxbY9EzZSQBy-30Ey06H-+Bi4HcQvxrOvEHANSGQmVg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox