public inbox for [email protected]  

help / color / mirror / Atom feed

From: Richard Guo <[email protected]>
To: Tender Wang <[email protected]>
Cc: Radim Marek <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Eager aggregation, take 3
Date: Wed, 3 Jun 2026 10:25:01 +0900
Message-ID: <CAMbWs49KSppYihVGz+c5uKJeRHtaG-a1wTG96d-ZMuEUmTO1Qw@mail.gmail.com> (raw)
In-Reply-To: <CAHewXNna2r7cbwuotFJBdsHAedu1hZ1OD1Aj_hoRDOmFw-7z2A@mail.gmail.com>
References: <CAMbWs48jzLrPt1J_00ZcPZXWUQKawQOFE8ROc-ADiYqsqrpBNw@mail.gmail.com>
	<CAJgoLk+d_P5sKrx-SZt01Acm_j0QnWn6aKJzFJ=waRu_3C8AoQ@mail.gmail.com>
	<CAHewXNkdhBrQR3mRmLw6FThgXd-tD2LmgfLreb+OeiyXmO2PPQ@mail.gmail.com>
	<CAMbWs49zScoONs0151cmgoo5cttkkK2cGLx228+Wok-h8XoyOg@mail.gmail.com>
	<CAHewXNna2r7cbwuotFJBdsHAedu1hZ1OD1Aj_hoRDOmFw-7z2A@mail.gmail.com>

On Mon, Jun 1, 2026 at 4:57 PM Tender Wang <[email protected]> wrote:
> Richard Guo <[email protected]> 于2026年6月1日周一 15:19写道：
> > So I'd rather fix it in eager_aggregation_possible_for_relation, right
> > next to the existing outer-join check, by rejecting a relation that
> > lies on the inner side of a semijoin/antijoin.  See attached.

> The attached LGTM.

Thanks for the review.  Pushed.

And thanks to Radim for the report and the well-contained repro.

- Richard

view thread (55+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Eager aggregation, take 3
  In-Reply-To: <CAMbWs49KSppYihVGz+c5uKJeRHtaG-a1wTG96d-ZMuEUmTO1Qw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox