public inbox for [email protected]  

help / color / mirror / Atom feed

From: Richard Guo <[email protected]>
To: Andrei Lepikhov <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Some dead code in get_param_path_clause_serials()
Date: Tue, 26 Nov 2024 09:48:58 +0900
Message-ID: <CAMbWs4_tC4teQuqPjbhtwTM930djDjUfjBUPoYgMiBWWdhzngQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAMbWs4_Puie4DQ2ODvjQB_3CxYkUODnrJm8jn_ObMAcrjYNW7Q@mail.gmail.com>
	<[email protected]>

On Wed, Nov 13, 2024 at 9:59 PM Andrei Lepikhov <[email protected]> wrote:
> On 11/13/24 16:34, Richard Guo wrote:
> > The function get_param_path_clause_serials() is used to get the set of
> > pushed-down clauses enforced within a parameterized Path.  Since we
> > don't currently support parameterized MergeAppend paths, and it
> > doesn't look like that is going to change anytime soon (as explained
> > in the comments for generate_orderedappend_paths), we don't need to
> > consider MergeAppendPath in this function.  Is it worth removing the
> > related code, as attached?

> I've passed through the logic of
> get_param_path_clause_serials/reparameterize_path_by_child/reparameterize_path.
> Agree, it seems not useful to parameterise ordered appends in the near
> future.

Pushed.  Thank you for review.

Thanks
Richard

view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Some dead code in get_param_path_clause_serials()
  In-Reply-To: <CAMbWs4_tC4teQuqPjbhtwTM930djDjUfjBUPoYgMiBWWdhzngQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox