public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daria Shanina <[email protected]>
To: Robert Haas <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: [email protected]
Subject: Re: autoprewarm_dump_now
Date: Tue, 17 Jun 2025 18:15:32 +0300
Message-ID: <CAMp4U1cAXDKCwV4Cj=c6E2kAUD=3s9LBpPWHtfhwiFahF16iCw@mail.gmail.com> (raw)
In-Reply-To: <CA+TgmoYM_=Jqo8dRSto2foqsxN5DPoMy_9P53pcYSFKzXD652A@mail.gmail.com>
References: <CAMp4U1cDJzb96KJXT-hNuf7L4KaYUiXWs6KSe01so--mBoop8g@mail.gmail.com>
<[email protected]>
<CAAKRu_YyuqbRaVO-zkoeRLFeNtF_jX-faGSGH4h3JB6ckORWMg@mail.gmail.com>
<CA+TgmobRMXwFg4AUZ96FvXALFkN8H7KBqhCp-CtMS83RuKXG3A@mail.gmail.com>
<CAMp4U1c8S7oTsuNahvkFLR7OeSxnamtOHgey=rcMi=Y7cWg7ng@mail.gmail.com>
<[email protected]>
<CAMp4U1doDjku1675GRRtpwML2aGsYqjC0SZBm7xozGfQiBfCug@mail.gmail.com>
<CA+TgmoYCMwr1BxE5ApJoxkqxrzSSvS509xqow4HY1-y90HjnJA@mail.gmail.com>
<kbv4jauor5mltu6blx7bov4c57gbjvptvakvyngdzizfn7clqf@minothylwk6e>
<CA+TgmoYM_=Jqo8dRSto2foqsxN5DPoMy_9P53pcYSFKzXD652A@mail.gmail.com>
Hi,
I launched pgindent and created a new patch. Here it is.
*quakes in fear of incoming buildfarm results*
I hope there will be good results at buildfarm.
пт, 6 июн. 2025 г. в 16:19, Robert Haas <[email protected]>:
> On Tue, Jun 3, 2025 at 2:58 PM Andres Freund <[email protected]> wrote:
> > > I think the proposed patch should be committed and back-patched, after
> > > fixing it so that it's pgindent-clean and adding a comment. Does
> > > anyone have strong objection to that?
> >
> > No, seems like a thing that pretty obviously should be fixed.
>
> Done.
>
> *quakes in fear of incoming buildfarm results*
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>
--
Best regards,
Daria Shanina
Attachments:
[text/x-patch] v1-0001-PGPRO-9971-Allocate-enough-memory-with-huge-share_buffers.patch (928B, ../CAMp4U1cAXDKCwV4Cj=c6E2kAUD=3s9LBpPWHtfhwiFahF16iCw@mail.gmail.com/3-v1-0001-PGPRO-9971-Allocate-enough-memory-with-huge-share_buffers.patch)
download | inline diff:
From a4776e4ae0c2ffe3061b64dec7ac60d730db12b0 Mon Sep 17 00:00:00 2001
From: Darya Shanina <[email protected]>
Date: Tue, 22 Apr 2025 11:27:01 +0300
Subject: [PATCH v1] [PGPRO-9971] Allocate enough memory with huge
shared_buffers. Tags: commitfest_hotfix
---
contrib/pg_prewarm/autoprewarm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/contrib/pg_prewarm/autoprewarm.c b/contrib/pg_prewarm/autoprewarm.c
index d061731706a..4dbda58eeae 100644
--- a/contrib/pg_prewarm/autoprewarm.c
+++ b/contrib/pg_prewarm/autoprewarm.c
@@ -597,8 +597,9 @@ apw_dump_now(bool is_bgworker, bool dump_unlogged)
return 0;
}
- block_info_array =
- (BlockInfoRecord *) palloc(sizeof(BlockInfoRecord) * NBuffers);
+ block_info_array = (BlockInfoRecord *)
+ palloc_extended((sizeof(BlockInfoRecord) * NBuffers),
+ MCXT_ALLOC_HUGE);
for (num_blocks = 0, i = 0; i < NBuffers; i++)
{
--
2.43.0
view thread (15+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: autoprewarm_dump_now
In-Reply-To: <CAMp4U1cAXDKCwV4Cj=c6E2kAUD=3s9LBpPWHtfhwiFahF16iCw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox