public inbox for [email protected]
help / color / mirror / Atom feedRe: Custom oauth validator options
3+ messages / 2 participants
[nested] [flat]
* Re: Custom oauth validator options
@ 2026-01-28 19:21 Zsolt Parragi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Zsolt Parragi @ 2026-01-28 19:21 UTC (permalink / raw)
To: Álvaro Herrera <[email protected]>; +Cc: Jacob Champion <[email protected]>; VASUKI M <[email protected]>; PostgreSQL Hackers <[email protected]>; [email protected]; Robert Haas <[email protected]>; [email protected]; Nikolay Shaplov <[email protected]>
> but I wonder if this is something we
> should attempt in the context of the larger refactoring done by the
> patch series here,
That patch series is interesting but it is about SQL (table, index,
operator) options, while this is about guc variable validation and
extension. These seem unrelated to me.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Custom oauth validator options
@ 2026-01-29 11:58 Nikolay Shaplov <[email protected]>
parent: Zsolt Parragi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Shaplov @ 2026-01-29 11:58 UTC (permalink / raw)
To: Zsolt Parragi <[email protected]>; Álvaro Herrera <[email protected]>; +Cc: Jacob Champion <[email protected]>; VASUKI M <[email protected]>; PostgreSQL Hackers <[email protected]>; [email protected]; Robert Haas <[email protected]>; [email protected]
On 28.01.2026 22:21, Zsolt Parragi wrote:
>> but I wonder if this is something we
>> should attempt in the context of the larger refactoring done by the
>> patch series here,
> That patch series is interesting but it is about SQL (table, index,
> operator) options, while this is about guc variable validation and
> extension. These seem unrelated to me.
This patch suggests context independent API for managing extension
defined sets of options. It is used for
relation options and similar options, but cat be also used for any
options sets, may be with small modifications.
GUC options are almost same options as relation options. That is why, I
guess, Alvaro suggested you to look at this patch.
And I agree with him. Please have a look at
src/backend/access/common/options.c in that patch. I almost sure this
code can be reused for GUC options too.
Whole https://commitfest.postgresql.org/patch/4688/ is a bit outdated,
and need rebase, but options.c from it is as good as it was before.
And we've just recently committed a small fix that have been blocking
4688's patch rebase. I have plans to rebase it in not so distant future.
It you find it useful for your tasks and even would like to join to
review (at least for options.c part) I would do it with higher priority.
(but it is still my weekend-days project, so it can't be extremely fast)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Custom oauth validator options
@ 2026-01-29 13:00 Zsolt Parragi <[email protected]>
parent: Nikolay Shaplov <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Zsolt Parragi @ 2026-01-29 13:00 UTC (permalink / raw)
To: Nikolay Shaplov <[email protected]>; +Cc: Álvaro Herrera <[email protected]>; Jacob Champion <[email protected]>; VASUKI M <[email protected]>; PostgreSQL Hackers <[email protected]>; [email protected]; Robert Haas <[email protected]>; [email protected]
> This patch suggests context independent API for managing extension
> defined sets of options. It is used for
> relation options and similar options, but cat be also used for any
> options sets, may be with small modifications.
>
> GUC options are almost same options as relation options. That is why, I
> guess, Alvaro suggested you to look at this patch.
Yes, but wouldn't that still require a generic refactoring of GUCs?
I'm not saying that would be a bad thing, but that's a big task in
itself.
But if I think about it in the general context of this thread (adding
extension options to pg_hba, ignoring the part that I tried to
implement it with GUCs in the current patch), that can be related.
Thanks for the clarification, I'll look into it in more detail.
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-01-29 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-28 19:21 Re: Custom oauth validator options Zsolt Parragi <[email protected]>
2026-01-29 11:58 ` Nikolay Shaplov <[email protected]>
2026-01-29 13:00 ` Zsolt Parragi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox