public inbox for [email protected]  

help / color / mirror / Atom feed

From: Zsolt Parragi <[email protected]>
To: Jelte Fennema-Nio <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Dave Cramer <[email protected]>
Cc: Jacob Champion <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
Date: Wed, 25 Feb 2026 15:08:39 +0000
Message-ID: <CAN4CZFMLpakQb8qohDAnrOoQ1-UrvmzJewZss95Y+Mf_J+iNeA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAN4CZFOw2v9G_9vuP0vnNH8K9X_UeSOyq=gWJp7bdGZ5HKNTDA@mail.gmail.com>
	<[email protected]>
	<[email protected]>

+ /*
+ * Only signal regular backends, since those need to notify
+ * their clients using a GoAway message.
+ */
+ if (bp->bkend_type == B_BACKEND)

This condition is slightly different to how SignalChildren works, is
that intentional? I don't think it causes any practical difference,
and I don't see an easy way to reuse SignalChildren for this, but
maybe it could still follow the same pattern.

Otherwise I don't see any other issues, and this also doesn't seem to
be an important comment.

Since the pytest framework seems unlikely to be included in PG19, have
you considered a different test implementation, to have at least some
minimal coverage?

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
  In-Reply-To: <CAN4CZFMLpakQb8qohDAnrOoQ1-UrvmzJewZss95Y+Mf_J+iNeA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox