public inbox for [email protected]
help / color / mirror / Atom feedFrom: Zsolt Parragi <[email protected]>
To: shihao zhong <[email protected]>
Cc: songjinzhou <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: [Patch] New pg_stat_tablespace view
Date: Tue, 24 Mar 2026 22:11:01 +0000
Message-ID: <CAN4CZFPf-VhzkXMsWjncXBVBc9vjw2tasJz99iN6MMCaMLna6g@mail.gmail.com> (raw)
In-Reply-To: <CAGRkXqTaxN+cqNz-qaMRWmcXC7SVmgTAb++6MZwpXTZj-EUB0A@mail.gmail.com>
References: <CAGRkXqRHsZw3+aeNZgnBYduQSY7qg1O4MBdmyFjK-A+TU1-b-A@mail.gmail.com>
<CAGRkXqRp+mK_uuCEp+wuBvuvFf_1v=MGC6Dd6HgJigJUzZanHg@mail.gmail.com>
<[email protected]>
<CAGRkXqTaxN+cqNz-qaMRWmcXC7SVmgTAb++6MZwpXTZj-EUB0A@mail.gmail.com>
Hello!
blk_read_time and blk_write_time doesn't seem to work, they show 0 to
me even after some workloads, and I don't see any assignments in the
code. The testcase also checks for "blk_read_time >= 0" which
trivially succeeds.
blocks_fetched is also misleading, it includes both reads and cache
hits. pg_stat_database calls this column blocks_read, and properly
substracts blocks_hit from it.
+ rel->pgstat_info->reltablespace = rel->rd_locator.spcOid;
Shouldn't this be included in TwoPhasePgStatRecord / pgstat_twophase_postcommit?
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [Patch] New pg_stat_tablespace view
In-Reply-To: <CAN4CZFPf-VhzkXMsWjncXBVBc9vjw2tasJz99iN6MMCaMLna6g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox