public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nazir Bilal Yavuz <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Remove unnecessary 'always:' from CompilerWarnings task
Date: Thu, 9 Nov 2023 10:53:13 +0300
Message-ID: <CAN55FZ0of+tDpz5o-tA+bJ9ribjXj7gi6MTm5QP2McRfv4X2rg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAN55FZ3o52jRfEn=NEVRV4OxsWO4v-urtS-ADZwfoe=AT5PPCg@mail.gmail.com>
	<[email protected]>

Hi,

Thanks for the review.

On Wed, 8 Nov 2023 at 10:31, Peter Eisentraut <[email protected]> wrote:
>
> On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
> > There are multiple 'always:' keywords under the CompilerWarnings task.
> > Instead of that, we can use one 'always:' and move the instructions
> > under this. So, I removed unnecessary ones and rearranged indents
> > according to that change.
>
> I'm not sure this change is beneficial.  The way the code is currently
> arranged, it's a bit easier to move or change individual blocks, and
> it's also easier to read the file, because the "always:" is next to each
> "script" and doesn't scroll off the screen.

That makes sense. I am planning to withdraw this soon if there are no
other objections.

Regards,
Nazir Bilal Yavuz
Microsoft

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove unnecessary 'always:' from CompilerWarnings task
  In-Reply-To: <CAN55FZ0of+tDpz5o-tA+bJ9ribjXj7gi6MTm5QP2McRfv4X2rg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox