public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bilal Yavuz <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Chao Li <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Cleanup shadows variable warnings, round 1
Date: Thu, 4 Dec 2025 16:04:07 +0300
Message-ID: <CAN55FZ2M3J38q6PpPjuD-SjxiFDLn-80nR6Xj=kf4vU4h3rHgA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEoWx2mgTMAvXDi0AZVMeKys0owGa5tdQUJ0gonAjsdBOYMNkg@mail.gmail.com>
	<[email protected]>

Hi,

On Thu, 4 Dec 2025 at 14:21, Álvaro Herrera <[email protected]> wrote:
>
> On 2025-Dec-04, Chao Li wrote:
>
> > The motivation is that CF’s CI currently fails on shadow-variable warnings.
> > If you touch a file like a.c, and that file already has a legacy shadowing
> > issue, CI will still fail your patch even if your changes are correct. Then
> > you’re forced to fix unrelated shadow-variable problems just to get a clean
> > CI run. I’ve run into this myself, and it’s disruptive for both patch
> > authors and reviewers.
>
> Hmm, maybe that should be turned off.  It sounds seriously unhelpful.

To test that I created this CI run [1], which edits the brin.c file.
That file has a legacy shadowing issue but the CI did not fail. Could
you please show an example CI run?

[1] https://cirrus-ci.com/build/5444936843132928

--
Regards,
Nazir Bilal Yavuz
Microsoft

view thread (30+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Cleanup shadows variable warnings, round 1
  In-Reply-To: <CAN55FZ2M3J38q6PpPjuD-SjxiFDLn-80nR6Xj=kf4vU4h3rHgA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox