public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nazir Bilal Yavuz <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Miłosz Bieniek <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
Date: Wed, 18 Mar 2026 18:36:56 +0300
Message-ID: <CAN55FZ2Pa31vOuiFH+=pAyJUK1C83GQ1-14RERhxL+pBYZ0qjQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAMSWrt-PoQt4sHryWrB1ViuGBJF_PpbjoSGrWR2Ry47bHNLDqg@mail.gmail.com>
<[email protected]>
<CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com>
<CAN55FZ1OkRkQMT==EtTWesKBFdBG28WrzhYsex3UG67F7bAQ8A@mail.gmail.com>
<CAN55FZ2fc++9-G=Mc4D2rNV2wQdbFn6EWszMno18vQTdqnKpJw@mail.gmail.com>
<CAMSWrt-2riJci+iGvt=Dggb4eh=2HgP3hy6+K=rZSeW=XFczAw@mail.gmail.com>
<CAN55FZ2vFfRJ5Ewj44oo27J=qY=E9+3d8S_rcMbuGJP-Rm7yPQ@mail.gmail.com>
<[email protected]>
<[email protected]>
Hi,
On Wed, 18 Mar 2026 at 14:59, Peter Eisentraut <[email protected]> wrote:
>
> On 18.03.26 11:56, Peter Eisentraut wrote:
> >
> > Committed that, but without the regular expression changes. I don't
> > understand why those would be needed. Please provide more information
> > if necessary. It worked for me without it.
It is working now. I can't reproduce the problem, it looks like it is
already fixed.
> I need another tweak for the cpluspluscheck.
>
> In meson, the distribution of the include flags between CPPFLAGS,
> CFLAGS, and CXXFLAGS ends up being a bit different, and we need to get a
> few -I options from CXXFLAGS in my case.
>
> I have attached two different variants for how to do this. The first
> one just gets the -D and -I flags from CXXFLAGS. This preserves most of
> the existing behavior. The second aligns more with how CFLAGS works and
> removes the ability to override CXXFLAGS from the command line. This is
> probably now better since we have more support for getting correct CXX
> and CXXFLAGS in the build system. But it might be a change for some users.
>
> Thoughts?
I think we can go with the second variant first. If there is a
complaint, we can then consider switching to the first one. Does that
sound good? Also, second patch probably needs to remove lines below
from the src/tools/pginclude/README:
```
If you are using a non-g++-compatible C++ compiler, you may need to
override the script's CXXFLAGS setting by setting a suitable environment
value.
```
--
Regards,
Nazir Bilal Yavuz
Microsoft
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
In-Reply-To: <CAN55FZ2Pa31vOuiFH+=pAyJUK1C83GQ1-14RERhxL+pBYZ0qjQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox