public inbox for [email protected]
help / color / mirror / Atom feedFrom: John Naylor <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Yugo Nagata <[email protected]>
Cc: Pgsql Hackers <[email protected]>
Subject: Re: Adjust error message for CREATE STATISTICS to account for expressions
Date: Fri, 27 Mar 2026 07:45:37 +0700
Message-ID: <CANWCAZaZeX0omWNh_ZbD_JVujzYQdRUW8UZOQ4dWh9Sg7OcAow@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CANWCAZYdyQzCoAiq9kybHT2RcnC1CgrxbCpyxeV3+KZn2xj2UA@mail.gmail.com>
<[email protected]>
<CANWCAZYjDSsvC6M6pas26ffbj-TZmXOHHC1-DwRM2LFa+qr3GQ@mail.gmail.com>
<[email protected]>
On Fri, Mar 27, 2026 at 6:23 AM Michael Paquier <[email protected]> wrote:
> - errmsg("extended statistics require at least 2 columns")));
> + errmsg("extended statistics are not supported on a single column")));
>
> Now our documentation also tells that the former message is not the
> preferred project style (full sentences usually avoided in primary
> messages):
> https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-GUIDE-GRAMMAR-PUNCTUATION
My reading of that is that hints/details need to be complete
sentences, and primary messages don't need to be. If the obvious way
to write primary message is with a complete sentence, I would say
that's fine, but I don't have a lot of context here.
> Perhaps something like "could not create extended statistics" with a
> hint describing the cause would be better.. Full sentences usually
> apply to errdetails or errhints. If we're on it, we could just as
> well improve the whole thing, I guess?
I don't feel strongly either way, so in that case I would default to
not changing to errdetail. Looking elsewhere in this file, however, I
do see some messages with "cannot do X because ....", and I'd be more
motivated to turn those "because" phrases into errdetails.
--
John Naylor
Amazon Web Services
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Adjust error message for CREATE STATISTICS to account for expressions
In-Reply-To: <CANWCAZaZeX0omWNh_ZbD_JVujzYQdRUW8UZOQ4dWh9Sg7OcAow@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox