public inbox for [email protected]  

help / color / mirror / Atom feed

From: John Naylor <[email protected]>
To: zengman <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: [PATCH] Precompute string lengths in PerformRadiusTransaction
Date: Wed, 25 Mar 2026 16:51:26 +0700
Message-ID: <CANWCAZahqjM9_XVRXpV=M9Y7fDiywUFrXUYpBebvxQxdYj+NSA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Mon, Jan 5, 2026 at 9:36 PM zengman <[email protected]> wrote:
> I noticed that the `PerformRadiusTransaction` function is invoked in a loop,
> and the function itself contains internal loops that repeatedly call strlen() on the 'passwd' and 'secret' strings.
> While the optimization gain may be minimal, I still think it’s worth making the change —
> we can precompute the lengths of these two strings at the start of the function to eliminate redundant strlen() calls.

Shortly after you posted this, it was decided that we're going to
remove this method entirely:

https://wiki.postgresql.org/wiki/RADIUS

-- 
John Naylor
Amazon Web Services

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Precompute string lengths in PerformRadiusTransaction
  In-Reply-To: <CANWCAZahqjM9_XVRXpV=M9Y7fDiywUFrXUYpBebvxQxdYj+NSA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox