public inbox for [email protected]
help / color / mirror / Atom feedRe: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs
3+ messages / 3 participants
[nested] [flat]
* Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs
@ 2026-01-09 22:01 surya poondla <[email protected]>
2026-01-16 09:35 ` Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs Aditya Gollamudi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: surya poondla @ 2026-01-09 22:01 UTC (permalink / raw)
To: Dharin Shah <[email protected]>; +Cc: [email protected]
Hi Dharin,
I looked at your patch, it looks good.
In the code, I couldn’t find any 2^64 bound on the lexeme count, so
removing that makes sense.
The added sentence about distinct lexeme count seems to overlap with the
existing description of tsvector limits, so I’m not sure it adds much new
information.
-Surya Poondla
>
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs
2026-01-09 22:01 Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs surya poondla <[email protected]>
@ 2026-01-16 09:35 ` Aditya Gollamudi <[email protected]>
2026-03-26 22:48 ` Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs Dharin Shah <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Aditya Gollamudi @ 2026-01-16 09:35 UTC (permalink / raw)
To: surya poondla <[email protected]>; +Cc: Dharin Shah <[email protected]>; [email protected]
On Fri, Jan 9, 2026 at 2:01 PM surya poondla <[email protected]>
wrote:
> Hi Dharin,
>
> I looked at your patch, it looks good.
>
> In the code, I couldn’t find any 2^64 bound on the lexeme count, so
> removing that makes sense.
> The added sentence about distinct lexeme count seems to overlap with the
> existing description of tsvector limits, so I’m not sure it adds much new
> information.
>
> -Surya Poondla
>
+1 on this patch, I was also a bit confused on this part of the
documentation. All I could conclude was that the number of lexemes in a
tsvector was limited by existing tsvector limits. I agree with Surya's
comment about the overlap, I think this patch should only remove the line
about the 2^64 bound. Patch applies cleanly!
Adi Gollamudi
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs
2026-01-09 22:01 Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs surya poondla <[email protected]>
2026-01-16 09:35 ` Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs Aditya Gollamudi <[email protected]>
@ 2026-03-26 22:48 ` Dharin Shah <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Dharin Shah @ 2026-03-26 22:48 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Aditya Gollamudi <[email protected]>; surya poondla <[email protected]>; [email protected]
Sorry to drop the ball on this, will get back to cleaning it up and create
a new patch
Thanks,
Dharin
On Thu, Mar 26, 2026 at 11:02 PM Tom Lane <[email protected]> wrote:
> Aditya Gollamudi <[email protected]> writes:
> > +1 on this patch, I was also a bit confused on this part of the
> > documentation. All I could conclude was that the number of lexemes in a
> > tsvector was limited by existing tsvector limits. I agree with Surya's
> > comment about the overlap, I think this patch should only remove the line
> > about the 2^64 bound. Patch applies cleanly!
>
> What I'm inclined to do is just drop that <listitem> entirely,
> since it's implied by the 1MB space limit. The patch as-submitted
> accomplishes about the same thing, but takes more words to do it.
>
> regards, tom lane
>
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-03-26 22:48 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-09 22:01 Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs surya poondla <[email protected]>
2026-01-16 09:35 ` Aditya Gollamudi <[email protected]>
2026-03-26 22:48 ` Dharin Shah <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox