public inbox for [email protected]  

help / color / mirror / Atom feed

From: Etsuro Fujita <[email protected]>
To: Andreas Karlsson <[email protected]>
Cc: Lev Nikolaev <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] analyze: move elevel calculation into do_analyze_rel()
Date: Thu, 2 Apr 2026 20:14:37 +0900
Message-ID: <CAPmGK14Mxuv+O7WauBEDN6usnPq77E=p90FU3C22=QJcQogMpA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Thu, Apr 2, 2026 at 8:29 AM Andreas Karlsson <[email protected]> wrote:
> On 3/31/26 7:56 PM, Lev Nikolaev wrote:
> > I reworked the patch slightly.
>
> This small cleanup makes sense to me since do_analyze_rel() already
> looks at if VACOPT_VERBOSE is set meaning related code is grouped closer
> after this small refactoring.
>
> The patch no longer applied so I rebased it.

Sorry, but -1 from me because this change would lead to doing the same
setup repeatedly when analyzing inheritance trees, which is not great.

Best regards,
Etsuro Fujita

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] analyze: move elevel calculation into do_analyze_rel()
  In-Reply-To: <CAPmGK14Mxuv+O7WauBEDN6usnPq77E=p90FU3C22=QJcQogMpA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox