public inbox for [email protected]  

help / color / mirror / Atom feed

From: Etsuro Fujita <[email protected]>
To: Andy Fan <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Comment in portal.h
Date: Thu, 1 Aug 2024 18:05:47 +0900
Message-ID: <CAPmGK1629_03401siY5_tbC_h_HiZmx+EGg3nFzdxyE76iRpKg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAPmGK14HVYBZYZtHabjeCd-e31VT=wx6rQNq8QfehywLcpZ2Hw@mail.gmail.com>
	<[email protected]>

Hi,

On Wed, Jul 31, 2024 at 8:55 AM Andy Fan <[email protected]> wrote:
> Etsuro Fujita <[email protected]> writes:
> > I noticed $SUBJECT while working on something else:
> >
> >     /*
> >      * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
> >      * PORTAL_UTIL_SELECT query.  (A cursor held past the end of its
> >      * transaction no longer has any active executor state.)
> >      */
> >     Tuplestorestate *holdStore; /* store for holdable cursors */
> >     MemoryContext holdContext;  /* memory containing holdStore */
> >
> > We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
> > "Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
> > PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.".  Attached is a
> > patch for that.
>
> Patch looks good to me.
>
> All the codes of PortalRun & FillPortalStore & PortalRunSelect are
> consistent with this idea.

Pushed.  Thanks for looking!

Best regards,
Etsuro Fujita

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Comment in portal.h
  In-Reply-To: <CAPmGK1629_03401siY5_tbC_h_HiZmx+EGg3nFzdxyE76iRpKg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox