From: Andy Fan <zhihuifan1213@163.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Comment in portal.h
Date: Wed, 31 Jul 2024 07:55:39 +0800
Message-ID: <87plqusadg.fsf@163.com> (raw)
In-Reply-To: <CAPmGK14HVYBZYZtHabjeCd-e31VT=wx6rQNq8QfehywLcpZ2Hw@mail.gmail.com>
References: <CAPmGK14HVYBZYZtHabjeCd-e31VT=wx6rQNq8QfehywLcpZ2Hw@mail.gmail.com>
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> Hi,
>
> I noticed $SUBJECT while working on something else:
>
> /*
> * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
> * PORTAL_UTIL_SELECT query. (A cursor held past the end of its
> * transaction no longer has any active executor state.)
> */
> Tuplestorestate *holdStore; /* store for holdable cursors */
> MemoryContext holdContext; /* memory containing holdStore */
>
> We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
> "Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
> PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.". Attached is a
> patch for that.
Patch looks good to me.
All the codes of PortalRun & FillPortalStore & PortalRunSelect are
consistent with this idea.
--
Best Regards
Andy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: zhihuifan1213@163.com, etsuro.fujita@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Comment in portal.h
In-Reply-To: <87plqusadg.fsf@163.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox