public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Korotkov <[email protected]>
To: Noah Misch <[email protected]>
Cc: Pavel Borisov <[email protected]>
Cc: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: Andrei Lepikhov <[email protected]>
Cc: jian he <[email protected]>
Cc: Artur Zakirov <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: Teodor Sigaev <[email protected]>
Cc: Pgsql Hackers <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Michael Paquier <[email protected]>
Subject: Re: type cache cleanup improvements
Date: Sat, 12 Apr 2025 00:43:19 +0300
Message-ID: <CAPpHfdtRvDtoVCN0fMVCUDong2eX-o4ATKJCQ9F0epPmm83rZA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAPpHfdt_dN5vyQQsTV=yeD+guDW7H7cvfkKj_mSETT0BEbyL+Q@mail.gmail.com>
<CAPpHfdvK8XS-FvXSxcEr-=azS3SHJo3b0yrQCq4uOv4fsw0JGw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAPpHfdvMVevMxAob4Yav9LyW2a4nrWqxUVQ8K1=Hs7EjOPQk1w@mail.gmail.com>
<[email protected]>
<CAPpHfduqZFZYL63Yx92pfAyiS8ACXyXSsnV1Geb_ecJTTU=Pmg@mail.gmail.com>
<CAPpHfdtHjPuLPoLGAqeUnttxy-PooJNB4piiZraLXK2C8e8vwg@mail.gmail.com>
<CALT9ZEHh4-K5ofp+EKO8MdCQJWMWkrq3mZstWPJda8feSdnT-g@mail.gmail.com>
<CAPpHfdv=WVCbzdpoTxvXzUZZEqu_pDk2YZBnEGpUCrzuHxPN6w@mail.gmail.com>
<[email protected]>
On Fri, Apr 11, 2025 at 11:32 PM Noah Misch <[email protected]> wrote:
>
> On Tue, Oct 22, 2024 at 08:33:24PM +0300, Alexander Korotkov wrote:
> > On Tue, Oct 22, 2024 at 6:10 PM Pavel Borisov <[email protected]> wrote:
> > > On Tue, 22 Oct 2024 at 11:34, Alexander Korotkov <[email protected]> wrote:
> > >> I'm going to push this if no objections.
>
> (This became commit b85a9d0.)
>
> > + /* Call delete_rel_type_cache() if we actually cleared something */
> > + if (hadTupDescOrOpclass)
> > + delete_rel_type_cache_if_needed(typentry);
>
> I think the intent was to maintain the invariant that a RelIdToTypeIdCacheHash
> entry exists if and only if certain kinds of data appear in the TypeCacheHash
> entry. However, TypeCacheOpcCallback() clears TCFLAGS_OPERATOR_FLAGS without
> maintaining RelIdToTypeIdCacheHash. Is it right to do that?
Thank you for the question. I'll recheck this in next couple of days.
------
Regards,
Alexander Korotkov
Supabase
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: type cache cleanup improvements
In-Reply-To: <CAPpHfdtRvDtoVCN0fMVCUDong2eX-o4ATKJCQ9F0epPmm83rZA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox