public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Korotkov <[email protected]>
To: Andrei Lepikhov <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Missing docs for new enable_group_by_reordering GUC
Date: Tue, 18 Jun 2024 15:13:11 +0300
Message-ID: <CAPpHfdtmVCrsEYWhugW9VRNGBCcmOVNa5-MtdvfJgwpNrMRAsQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Tue, Jun 18, 2024 at 9:14 AM Andrei Lepikhov <[email protected]> wrote:
> On 6/18/24 09:32, Bruce Momjian wrote:
> > This commit added enable_group_by_reordering:
> >
> > commit 0452b461bc4
> > Author: Alexander Korotkov <[email protected]>
> > Date: Sun Jan 21 22:21:36 2024 +0200
> > It mentions it was added as a GUC to postgresql.conf, but I see no SGML
> > docs for this new GUC value. Would someone please add docs for this?
> > Thanks.
> It is my mistake, sorry for that. See the patch in attachment.
Bruce, thank for noticing. Andrei, thank you for providing a fix.
Please, check the revised patch.
------
Regards,
Alexander Korotkov
Supabase
Attachments:
[application/octet-stream] v2-0001-Add-doc-entry-for-the-new-GUC-paramenter-enable_g.patch (2.0K, ../CAPpHfdtmVCrsEYWhugW9VRNGBCcmOVNa5-MtdvfJgwpNrMRAsQ@mail.gmail.com/2-v2-0001-Add-doc-entry-for-the-new-GUC-paramenter-enable_g.patch)
download | inline diff:
From f44436b9ebd3f63cdd4d1d3e1b46a8f660e5edac Mon Sep 17 00:00:00 2001
From: Alexander Korotkov <[email protected]>
Date: Tue, 18 Jun 2024 15:08:17 +0300
Subject: [PATCH v2] Add doc entry for the new GUC paramenter
enable_group_by_reordering
0452b461bc4 adds alternative orderings of group-by keys during the query
optimization. This new feature is controlled by the new GUC parameter
enable_group_by_reordering, which accidentally came without the documentation.
This commit adds the missing documentation for that GUC.
Reported-by: Bruce Momjian
Discussion: https://postgr.es/m/ZnDx2FYlba_OafQd%40momjian.us
Author: Andrei Lepikhov
---
doc/src/sgml/config.sgml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 698169afdb6..d45cb02ad15 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -5327,6 +5327,24 @@ ANY <replaceable class="parameter">num_sync</replaceable> ( <replaceable class="
</listitem>
</varlistentry>
+ <varlistentry id="guc-enable-groupby-reordering" xreflabel="enable_group_by_reordering">
+ <term><varname>enable_group_by_reordering</varname> (<type>boolean</type>)
+ <indexterm>
+ <primary><varname>enable_group_by_reordering</varname> configuration parameter</primary>
+ </indexterm>
+ </term>
+ <listitem>
+ <para>
+ Enables or disables the reordering of keys in a
+ <literal>GROUP BY</literal> clause to match the ordering keys of a
+ child node of the plan, such as an index scan. When turned off, keys
+ in a <literal>GROUP BY</literal> clause are only reordered to match
+ the <literal>ORDER BY</literal> clause, if any. The default is
+ <literal>on</literal>.
+ </para>
+ </listitem>
+ </varlistentry>
+
<varlistentry id="guc-enable-gathermerge" xreflabel="enable_gathermerge">
<term><varname>enable_gathermerge</varname> (<type>boolean</type>)
<indexterm>
--
2.39.3 (Apple Git-145)
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Missing docs for new enable_group_by_reordering GUC
In-Reply-To: <CAPpHfdtmVCrsEYWhugW9VRNGBCcmOVNa5-MtdvfJgwpNrMRAsQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox