public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Korotkov <[email protected]>
To: Zsolt Parragi <[email protected]>
Cc: David Geier <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Kirill Reshke <[email protected]>
Subject: Re: Use correct collation in pg_trgm
Date: Mon, 26 Jan 2026 15:33:50 +0200
Message-ID: <CAPpHfdvWbF2S6fsc+dF=7OjLG6iFXVcDH+MK0aVKzaH9iptLvQ@mail.gmail.com> (raw)
In-Reply-To: <CAN4CZFP5oVKkjAeb7-jrWR8spqvnhQq7HSTMhpWBiYuPmtqyjg@mail.gmail.com>
References: <[email protected]>
<CAN4CZFN83RsDejW5e9P1pCzAB6LKCgsBkAZk-4Y_UscBXtdJ1Q@mail.gmail.com>
<[email protected]>
<CAN4CZFP5oVKkjAeb7-jrWR8spqvnhQq7HSTMhpWBiYuPmtqyjg@mail.gmail.com>
Hi!
Thank you for working on this.
On Mon, Jan 26, 2026 at 3:24 PM Zsolt Parragi <[email protected]> wrote:
>
> > While reading through [1] I realized that the word boundary detection
> > also uses the wrong collation. Patch 0002 fixes that.
>
> Good catch, I considered checking that when I reviewed the patch, but
> I thought that it would be an issue with CJK languages, and I was
> completely wrong about that.
>
> Updated patch looks good, I only noticed two minor things:
>
> * the new test should have a newline at the end of the file
> * and probably a conditional skip based on locale availability, the
> citext_utf8.sql test case does something similar
I wonder about existing indexes, which already use default collation
not column collation. Should we add a release note saying they might
be obsolete? Alternatively, given we now have opclass options, we may
add a new opclass option defining whether to use column collation
(must be false for existing indexes).
------
Regards,
Alexander Korotkov
Supabase
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Use correct collation in pg_trgm
In-Reply-To: <CAPpHfdvWbF2S6fsc+dF=7OjLG6iFXVcDH+MK0aVKzaH9iptLvQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox