public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Korotkov <[email protected]>
To: Robert Haas <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Pavel Borisov <[email protected]>
Cc: Japin Li <[email protected]>
Cc: Mark Dilger <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Subject: Re: Table AM Interface Enhancements
Date: Mon, 8 Apr 2024 23:49:46 +0300
Message-ID: <CAPpHfdvxyqFLA+2JcaE5P8dpF7Vr8RVMxC-QQ2bjnd0oTDPw6A@mail.gmail.com> (raw)
In-Reply-To: <CA+TgmoZpWB50GnJZYF1x8PenTqXDTFBH_Euu6ybGfzEy34o+5Q@mail.gmail.com>
References: <CAPpHfdvz22sHkg7VpFB-XN1eZN6VfBY6mJc7zNa4aHZw+RqRXg@mail.gmail.com>
<ME3P282MB3166C45F15AB60418656CD7FB63B2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
<CALT9ZEH+RwH3DONih5VtxQBBqeeshFYJYXSA-vJSAXB0vfYwsA@mail.gmail.com>
<CALT9ZEFHbEok=F6MUD+9vGFC9O+zah3dYJg1iKFLrHnPbnP_Dw@mail.gmail.com>
<CALT9ZEEa=CQE2N+tY68yYr2Cp7GxOxWL3pQneDcsqkiWKoSb5Q@mail.gmail.com>
<CAPpHfdsmziv-+B3_7Va4ydkL9E-vh4RZF9qRR1oQiSqLHB4qpA@mail.gmail.com>
<[email protected]>
<CAPpHfduoywCT5iBcmp3bXiRsNUuBnjAkDDCjhzo6rDvqfdgMHg@mail.gmail.com>
<CALT9ZEF2m6U7NeTnbiRJvONPQr6mMvQM4ZY+3U_7BAggupiywA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAPpHfdtRQXSc5bEHyGW_XC9aj8qNygJgjUmDv8U7qdw2REXTdg@mail.gmail.com>
<CA+TgmoZpWB50GnJZYF1x8PenTqXDTFBH_Euu6ybGfzEy34o+5Q@mail.gmail.com>
On Mon, Apr 8, 2024 at 9:54 PM Robert Haas <[email protected]> wrote:
> On Mon, Apr 8, 2024 at 12:33 PM Alexander Korotkov <[email protected]> wrote:
> > Yes, it was my mistake. I got rushing trying to fit this to FF, even doing significant changes just before commit.
> > I'll revert this later today.
It appears to be a non-trivial revert, because 041b96802e already
revised the relation analyze after 27bc1772fc. That is, I would need
to "backport" 041b96802e. Sorry, I'm too tired to do this today.
I'll come back to this tomorrow.
> Alexander,
>
> Exactly how much is getting reverted here? I see these, all since March 23rd:
>
> dd1f6b0c17 Provide a way block-level table AMs could re-use
> acquire_sample_rows()
> 9bd99f4c26 Custom reloptions for table AM
> 97ce821e3e Fix the parameters order for
> TableAmRoutine.relation_copy_for_cluster()
> 867cc7b6dd Revert "Custom reloptions for table AM"
> b1484a3f19 Let table AM insertion methods control index insertion
> c95c25f9af Custom reloptions for table AM
> 27bc1772fc Generalize relation analyze in table AM interface
> 87985cc925 Allow locking updated tuples in tuple_update() and tuple_delete()
> c35a3fb5e0 Allow table AM tuple_insert() method to return the different slot
> 02eb07ea89 Allow table AM to store complex data structures in rd_amcache
It would be discouraging to revert all of this. Some items are very
simple, some items get a lot of work. I'll come back tomorrow and
answer all your points.
------
Regards,
Alexander Korotkov
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Table AM Interface Enhancements
In-Reply-To: <CAPpHfdvxyqFLA+2JcaE5P8dpF7Vr8RVMxC-QQ2bjnd0oTDPw6A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox