public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tristan Partin <[email protected]>
To: Andrew Dunstan <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Subject: Re: meson: pgxs Makefile.global differences
Date: Thu, 17 Aug 2023 14:45:54 -0500
Message-ID: <CUV2U1MR5T8E.2T55FGZG23INJ@gonk> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
On Thu Aug 17, 2023 at 2:32 PM CDT, Andrew Dunstan wrote:
> I started digging into a warning I noticed on my FDW builds where
> Postgres is built with meson, e.g.
> <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2023-08-16%2018%3A37%3A25...;
> which has this:
>
> cc1: warning: ‘-Wformat-security’ ignored without ‘-Wformat’
> [-Wformat-security]
>
> I found that the pgxs Makefile.global built under meson is a bit
> different. On debug builds for both this is what I get on HEAD (meson)
> and REL_15_STABLE (autoconf), stripped of the current components:
>
> HEAD: CFLAGS =-Wshadow=compatible-local
> REL_15_STABLE: CFLAGS =-Wall -g
>
> The warning is apparently due to the missing -Wall.
>
> Shouldn't we be aiming for pretty much identical settings?
I agree that they should be identical. The meson bild should definitely
be aiming for 100% compatibility for the Makefile.global.
--
Tristan Partin
Neon (https://neon.tech)
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: meson: pgxs Makefile.global differences
In-Reply-To: <CUV2U1MR5T8E.2T55FGZG23INJ@gonk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox