pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Matheus Alcantara <matheusssilv97@gmail.com>
To: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Rishu Bagga <rishu.postgres@gmail.com>
Cc: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: Daniil Davydov <3danissimo@gmail.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Alexandra Wang <alexandra.wang.oss@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Joel Jacobson <joel@compiler.org>
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
Date: Wed, 01 Oct 2025 08:57:38 -0300
Message-ID: <DD6YU9L1S3TS.2HLPSHSMNYRWV@gmail.com> (raw )
In-Reply-To: <CAE7r3MKmz3y4ztvG+4aMegLwYo5o=ohBWSXy05gG7PjdDSmfdw@mail.gmail.com >
References: <CAK98qZ3wZLE-RZJN_Y+TFjiTRPPFPBwNBpBi5K5CU8hUHkzDpw@mail.gmail.com >
<202508061044.ptcyt7aqsaaa@alvherre.pgsql >
<DBZN3PVLZ1UW.25XLKCUXYBVXV@gmail.com >
<CAJDiXgg1ArRB1-6wLtXfVVnQ38P9Y+CDfEc9M2TXiOf_4kfBMg@mail.gmail.com >
<CAFY6G8cnDOMZCfSvc62vER_9+HOs4EM52XromhOZki+=Ytv2sg@mail.gmail.com >
<CAJDiXgheRHTnK8RJuBBcF0VjQA83wi81oX2s-GvBV3x+eSwBbA@mail.gmail.com >
<CAFY6G8dyimRikP3nEK5gqMPnMZe5RTZjFvKvCFLJAvsajxK1fg@mail.gmail.com >
<CAJDiXgjQZgHLFziG6sS6D5CGYqohMio673ydiRkkffW3WfXmEg@mail.gmail.com >
<DC7KGTXW3QSG.OZA24HONT78J@gmail.com >
<CAD21AoCD+HXoc2QZCAS9d8ahDeikNqbnU0i6cQzpMFOEurkPPg@mail.gmail.com >
<DC8HKDZVIDYG.12H0X267CHMO5@gmail.com >
<CAFY6G8cJm73_MM9SuynZUqtqcaTuepUDgDuvS661oLW7U0dgsg@mail.gmail.com >
<d186fba0-dc65-4274-aa96-3906bbb2e530@postgrespro.ru >
<CAE7r3M+Xwf0A_aNhu7pYQd7nDQaqaEnyCjtvqg8XsgManmPOUA@mail.gmail.com >
<DCJH5HX8X3B4.O9P9P8VKKO1F@gmail.com >
<CAK80=jhxduhJmgSWY8JK4Aen8qshPGHFLE-J_ix6EN9AK6+sQQ@mail.gmail.com >
<CAFY6G8f0JEF3HE4Q+ZZYjpPiFfRREzJ+r6zbJh2ZUFb2jhqm7g@mail.gmail.com >
<CAE7r3MKiENVC==S8riqNPiMcgOp41npCDsNZFg=QXANd1Tajfg@mail.gmail.com >
<DCLS3QKXDT0W.364G3WTVMLGYR@gmail.com >
<CAD21AoBAcr6nAx5C4soYO3iR9dda_k8hFLok1Psd0R070qs9hg@mail.gmail.com >
<CAFY6G8fui7omKfUXF+JJ82B34ExrwK6J7vKe61S-DhEmr_jBhA@mail.gmail.com >
<CAE7r3M+=oOhDSmSihqGvdFzfgekF+6KibEXUJdCK7DdFTA8uPQ@mail.gmail.com >
<DCWUPJ39T21K.VY51UY0K8LE1@gmail.com >
<CAE7r3MK6e_WM0m4gbcDe7sHfKORtG=-Lv4a-77mG=mzZYK9zAQ@mail.gmail.com >
<DCZCQ91S4X48.2UKAFDY64R6TZ@gmail.com >
<CAE7r3MKaoTeNuSdzJCMpgEC9iVHnFXhswyDW3PtbYt5sKjXBOA@mail.gmail.com >
<DD0JHP2L085C.19I49XELORB20@gmail.com >
<CAE7r3M+Q4xjpU-gK-QtVOG32Nk=0-tT71fv7O-XorUXkhC7CAQ@mail.gmail.com >
<DD19XJL4GCZ4.2ZURAY378VT6M@gmail.com >
<CAE7r3MLe8XTALJeBK+2BfDsB0n1KkZqZ1kdaCqEhf8--xcf9JA@mail.gmail.com >
<CAE7r3MKmz3y4ztvG+4aMegLwYo5o=ohBWSXy05gG7PjdDSmfdw@mail.gmail.com >
On Sun Sep 28, 2025 at 10:17 AM -03, Arseniy Mukhin wrote:
>> I agree it would be great to have more tests for such cases. As for
>> the 'committed field' patch, I think we can add a TAP test that shows
>> that listeners postpone processing of notifications until
>> notifications were marked as 'committed=false' in case of aborted
>> transactions. I tried to write one, but have not succeeded yet. Hope
>> to finish it soon.
>
> I finally managed to write a TAP test for it, so there is a new
> version with the tap test.
>
> I also realized that we can increase test coverage in
> 002_aborted_tx_notifies.pl if notifications of the aborted transaction
> span several pages. This way we can better test
> asyncQueueRollbackNotifications(). So I changed
> 002_aborted_tx_notifies.pl TAP test a bit.
>
> And there is a small indentation change in lmgr.h that should fix this
> git am warning.
>
Thanks for the patches.
I've created a CF entry so we can get more reviews and comments:
https://commitfest.postgresql.org/patch/6095/
Let's see what other think about the approach being used to fix this
issue.
--
Matheus Alcantara
view thread (99+ messages) latest in thread
Message-ID: <DD6YU9L1S3TS.2HLPSHSMNYRWV@gmail.com>
Permalink: ../DD6YU9L1S3TS.2HLPSHSMNYRWV@gmail.com/
Also on: postgresql.org/message-id/DD6YU9L1S3TS.2HLPSHSMNYRWV@gmail.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: matheusssilv97@gmail.com, arseniy.mukhin.dev@gmail.com, sawada.mshk@gmail.com, rishu.postgres@gmail.com, y.sokolov@postgrespro.ru, 3danissimo@gmail.com, alvherre@kurilemu.de, alexandra.wang.oss@gmail.com, tgl@sss.pgh.pa.us, joel@compiler.org
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
In-Reply-To: <DD6YU9L1S3TS.2HLPSHSMNYRWV@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox