public inbox for [email protected]  

help / color / mirror / Atom feed

From: Matheus Alcantara <[email protected]>
To: Tom Lane <[email protected]>
To: Matheus Alcantara <[email protected]>
Cc: Joel Jacobson <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Optimize LISTEN/NOTIFY
Date: Tue, 07 Oct 2025 18:22:26 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAK80=jhmE40KVqQ3ho37MArS7cAED1p9m7uikDxcnDmqdW7t8A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+hUKGLrMGkWDB0cwTa0RqD+AF7O-Ywgck8aVYKwOQnZgYRRug@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAFY6G8dap-bCnAnMG-2Gzew8yv2Vbi9gsx9+yszKMmd57ygfvA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Tue Oct 7, 2025 at 6:17 PM -03, Tom Lane wrote:
> "Matheus Alcantara" <[email protected]> writes:
>> On Tue Oct 7, 2025 at 1:51 PM -03, Tom Lane wrote:
>>> Also, I don't think it's the job of this patch to provide test
>>> coverage for dshash.  That should be quite well covered already.
>
>> When I was mentioning to test that we can grow the dshash correctly it's
>> because the v9 patch has a logic to grow the array stored on dshash
>> entry value that currently is not being cover by the tests. I'm not
>> saying to test the dshash internal logic which I agree that it's not the
>> job of this patch. Sorry for being confusing.
>
> Ah, yeah, I misunderstood what you meant.  I agree that covering that
> "Grow the array" stanza is a good idea, in fact I said the same thing
> a little bit ago.
>
Yeah, I just saw your response after I sent the email, which I agree
with all the points. So I think that we are on the same "page" now.

--
Matheus Alcantara

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Optimize LISTEN/NOTIFY
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox